Skip to content
This repository was archived by the owner on Sep 23, 2026. It is now read-only.

fix(web): guard IME composition Enter keydowns - #2667

Closed
dvd233 wants to merge 1 commit into
MoonshotAI:mainfrom
dvd233:codex/fix/web-ime-composition-2643
Closed

dvd233 wants to merge 1 commit into
MoonshotAI:mainfrom
dvd233:codex/fix/web-ime-composition-2643

Conversation

@dvd233

@dvd233 dvd233 commented Sep 22, 2026 •

Copy link
Copy Markdown

Summary

When a CJK IME composition is active, WebKit can emit an Enter keydown with keyCode === 229 before isComposing is observable by React. PromptInputTextarea could then submit the incomplete text. Add the WebKit-compatible guard at the existing Enter submission boundary.

Normal Enter, Shift+Enter, Backspace, and submit-button handling are unchanged.

Verification

  • npm --prefix web run typecheck
  • npm --prefix web run build
  • git diff --check

Fixes #2643


Devin Review

Copilot AI lite review requested due to automatic review settings September 22, 2026 16:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@dvd233

dvd233 commented Sep 22, 2026

Copy link
Copy Markdown
Author

Closing this duplicate PR because #2658 already addresses #2643 with the same keyCode 229 IME guard. Please review #2658 as the canonical contribution.

@dvd233 dvd233 closed this Sep 22, 2026
@dvd233
dvd233 deleted the codex/fix/web-ime-composition-2643 branch September 22, 2026 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[kimi web] Enter pressed during IME composition is treated as 'send message'

2 participants