Revert "fix(core): allow static attributes for explicit input transforms"

This reverts commit 9b9b0e9.

This broke g3. Not sure yet why it didn't break externally. We can
investigate and fix following this revert.

Author: mattrbeck

goldens/public-api/core/index.api.md

@@ -1029,8 +1029,8 @@ export interface InputFunction {
     <T>(initialValue: undefined, opts: InputOptionsWithoutTransform<T>): InputSignal<T | undefined>;
     <T, TransformT>(initialValue: T, opts: InputOptionsWithTransform<T, TransformT>): InputSignalWithTransform<T, TransformT>;
     <T, TransformT>(initialValue: undefined, opts: InputOptionsWithTransform<T | undefined, TransformT>): InputSignalWithTransform<T | undefined, TransformT>;
-    <T>(initialValue: T, opts: InputOptionsWithTransform<T, unknown>): InputSignalWithTransform<T, T | string>;
-    <T>(initialValue: undefined, opts: InputOptionsWithTransform<T | undefined, unknown>): InputSignalWithTransform<T | undefined, T | undefined | string>;
+    <T>(initialValue: T, opts: InputOptionsWithTransform<T, unknown>): InputSignalWithTransform<T, T>;
+    <T>(initialValue: undefined, opts: InputOptionsWithTransform<T | undefined, unknown>): InputSignalWithTransform<T | undefined, T | undefined>;
     required: {
         <T>(opts?: InputOptionsWithoutTransform<T>): InputSignal<T>;
         <T, TransformT>(opts: InputOptionsWithTransform<T, TransformT>): InputSignalWithTransform<T, TransformT>;

packages/compiler-cli/test/ngtsc/authoring_inputs_spec.ts

@@ -320,66 +320,6 @@ runInEachFileSystem(() => {
         );
       });
 
-      it('should allow text attributes for explicit signal inputs with booleanAttribute transform', () => {
-        env.write(
-          'test.ts',
-          `
-          import {booleanAttribute, Component, Directive, input} from '@angular/core';
-
-          @Directive({
-            selector: '[directiveName]',
-          })
-          export class TestDir {
-            dismissible = input<boolean>(true, {transform: booleanAttribute});
-          }
-
-          @Component({
-            template: \`
-              <div directiveName [dismissible]="true"></div>
-              <div directiveName dismissible="true"></div>
-              <div directiveName dismissible></div>
-            \`,
-            imports: [TestDir],
-          })
-          export class TestComp {
-          }
-        `,
-        );
-
-        const diagnostics = env.driveDiagnostics();
-        expect(diagnostics).toEqual([]);
-      });
-
-      it('should allow text attributes for explicit signal inputs with numberAttribute transform', () => {
-        env.write(
-          'test.ts',
-          `
-          import {Component, Directive, input, numberAttribute} from '@angular/core';
-
-          @Directive({
-            selector: '[directiveName]',
-          })
-          export class TestDir {
-            count = input<number>(0, {transform: numberAttribute});
-          }
-
-          @Component({
-            template: \`
-              <div directiveName [count]="1"></div>
-              <div directiveName count="1"></div>
-              <div directiveName count=""></div>
-            \`,
-            imports: [TestDir],
-          })
-          export class TestComp {
-          }
-        `,
-        );
-
-        const diagnostics = env.driveDiagnostics();
-        expect(diagnostics).toEqual([]);
-      });
-
       it('should report unset required inputs', () => {
         env.write(
           'test.ts',

packages/core/src/authoring/input/input.ts

@@ -79,20 +79,17 @@ export interface InputFunction {
   ): InputSignalWithTransform<T | undefined, TransformT>;
   /**
    * Declares an input of type `T` with an initial value and a transform function
-   * that accepts values of the same type, or string values from static attributes.
+   * that accepts values of the same type.
    */
-  <T>(
-    initialValue: T,
-    opts: InputOptionsWithTransform<T, unknown>,
-  ): InputSignalWithTransform<T, T | string>;
+  <T>(initialValue: T, opts: InputOptionsWithTransform<T, unknown>): InputSignalWithTransform<T, T>;
   /**
    * Declares an input of type `T|undefined` without an initial value and with a transform
-   * function that accepts values of the same type, or string values from static attributes.
+   * function that accepts values of the same type.
    */
   <T>(
     initialValue: undefined,
     opts: InputOptionsWithTransform<T | undefined, unknown>,
-  ): InputSignalWithTransform<T | undefined, T | undefined | string>;
+  ): InputSignalWithTransform<T | undefined, T | undefined>;
 
   /**
    * Initializes a required input.

packages/core/test/authoring/signal_input_signature_test.ts

@@ -102,15 +102,15 @@ export class InputSignatureTest {
     transform: (v: string | boolean) => '',
   });
 
-  /** boolean, string | boolean */
+  /** boolean, boolean */
   explicitReadWithBooleanAttributeTransform = input<boolean>(false, {transform: booleanAttribute});
-  /** number, string | number */
+  /** number, number */
   explicitReadWithNumberAttributeTransform = input<number>(0, {transform: numberAttribute});
-  /** boolean | undefined, string | boolean | undefined */
+  /** boolean | undefined, boolean | undefined */
   explicitReadWithUndefinedInitialBooleanAttributeTransform = input<boolean>(undefined, {
     transform: booleanAttribute,
   });
-  /** number | undefined, string | number | undefined */
+  /** number | undefined, number | undefined */
   explicitReadWithUndefinedInitialNumberAttributeTransform = input<number>(undefined, {
     transform: numberAttribute,
   });