comments

Author: Rathoz

lua/wikis/commons/MatchSummary/Base.lua

@@ -60,8 +60,8 @@ end
 
 -- Default body function
 ---@param match MatchGroupUtilMatch
----@param createGames fun(match: MatchGroupUtilMatch): Renderable|Renderable[]?
----@param createGame fun(date: string, game: table, gameIndex: integer): Renderable|Renderable[]
+---@param createGames? fun(match: MatchGroupUtilMatch): Renderable|Renderable[]?
+---@param createGame? fun(date: string, game: table, gameIndex: integer): Renderable|Renderable[]
 ---@param options {maxBans: integer?}?
 ---@return Renderable[]
 function MatchSummary.createDefaultBody(match, createGames, createGame, options)
@@ -70,6 +70,8 @@ function MatchSummary.createDefaultBody(match, createGames, createGame, options)
 	local characterBansData = MatchSummary.buildCharacterBanData(match.games, options.maxBans or 0)
 
 	return WidgetUtil.collect(
+		--- we assume that createGames and createGame are mutually exclusive, so we can safely call one or the other
+		---@diagnostic disable-next-line: param-type-mismatch
 		createGames and createGames(match) or Array.map(match.games, FnUtil.curry(createGame, match.date)),
 		MatchSummaryWidgets.Mvp(match.extradata.mvp),
 		MatchSummaryWidgets.MapVeto(MatchSummary.preProcessMapVeto(match.extradata.mapveto, {game = match.game})),
@@ -221,7 +223,7 @@ function MatchSummary.defaultGetByMatchId(CustomMatchSummary, args, options)
 			type(CustomMatchSummary.createGame) == 'function' or
 			type(CustomMatchSummary.createGames) == 'function'
 		),
-		'createBody or createGame or createGames must be implemented in Module:MatchSummary'
+		'One of createBody or createGame or createGames must be implemented in Module:MatchSummary'
 	)
 
 	options = options or {}

lua/wikis/deadlock/MatchSummary.lua

@@ -40,7 +40,7 @@ function CustomMatchSummary.getByMatchId(args)
 end
 
 ---@param match MatchGroupUtilMatch
----@return VNode[]
+---@return VNode
 function CustomMatchSummary.createGames(match)
 	return MatchSummaryWidgets.GamesContainer{
 		children = Array.map(match.games, function (game, gameIndex)

lua/wikis/dota2/MatchSummary.lua

@@ -34,7 +34,7 @@ function CustomMatchSummary.getByMatchId(args)
 end
 
 ---@param match MatchGroupUtilMatch
----@return VNode[]
+---@return VNode
 function CustomMatchSummary.createGames(match)
 	return MatchSummaryWidgets.GamesContainer{
 		children = Array.map(match.games, function (game, gameIndex)

lua/wikis/honorofkings/MatchSummary.lua

@@ -34,7 +34,7 @@ function CustomMatchSummary.getByMatchId(args)
 end
 
 ---@param match MatchGroupUtilMatch
----@return VNode[]
+---@return VNode
 function CustomMatchSummary.createGames(match)
 	---@param game MatchGroupUtilGame
 	---@return boolean

lua/wikis/lab/MatchSummary.lua

@@ -29,7 +29,7 @@ function CustomMatchSummary.getByMatchId(args)
 end
 
 ---@param match MatchGroupUtilMatch
----@return VNode[]
+---@return VNode
 function CustomMatchSummary.createGames(match)
 	return MatchSummaryWidgets.GamesContainer{
 		children = Array.map(match.games, function (game, gameIndex)

lua/wikis/mobilelegends/MatchSummary.lua

@@ -34,7 +34,7 @@ function CustomMatchSummary.getByMatchId(args)
 end
 
 ---@param match MatchGroupUtilMatch
----@return VNode[]
+---@return VNode
 function CustomMatchSummary.createGames(match)
 	---@param game MatchGroupUtilGame
 	---@return boolean

lua/wikis/overwatch/MatchSummary.lua

@@ -32,7 +32,7 @@ function CustomMatchSummary.getByMatchId(args)
 end
 
 ---@param match MatchGroupUtilMatch
----@return VNode[]
+---@return VNode
 function CustomMatchSummary.createGames(match)
 	return MatchSummaryWidgets.GamesContainer{
 		children = Array.map(match.games, function (game, gameIndex)
@@ -57,6 +57,7 @@ function GameRowComponentProps.createGameOpponentView(props, opponentIndex)
 	local game = props.game
 	local opponentCopy = Table.deepCopy(game.opponents[opponentIndex])
 	if opponentCopy.score and game.mode == 'Push' then
+		---@diagnostic disable-next-line: assign-type-mismatch
 		opponentCopy.score = opponentCopy.score .. 'm'
 	end
 

lua/wikis/smash/MatchSummary.lua

@@ -42,15 +42,13 @@ end
 ---@param match MatchGroupUtilMatch
 ---@return Renderable[]
 function CustomMatchSummary.createGames(match)
-	return WidgetUtil.collect(
-		Array.map(match.games, function(game)
-			return CustomMatchSummary._createStandardGame(game, {
-				opponents = match.opponents,
-				game = match.game,
-				teamMode = CustomMatchSummary.isTeam(match),
-			})
-		end)
-	)
+	return Array.map(match.games, function(game)
+		return CustomMatchSummary._createStandardGame(game, {
+			opponents = match.opponents,
+			game = match.game,
+			teamMode = CustomMatchSummary.isTeam(match),
+		})
+	end)
 end
 
 ---@param game MatchGroupUtilGame