refactor(standings): use existing stash/retrieve functions for legacy ffa parsing (#8182)

use existing functions

Author: ElectricalBoy

lua/wikis/commons/Standings/Table/Legacy/Ffa.lua

@@ -9,9 +9,8 @@ local Lua = require('Module:Lua')
 
 local Arguments = Lua.import('Module:Arguments')
 local Array = Lua.import('Module:Array')
-local Json = Lua.import('Module:Json')
 local Table = Lua.import('Module:Table')
-local Variables = Lua.import('Module:Variables')
+local Template = Lua.import('Module:Template')
 
 local StandingTable = Lua.import('Module:Standings/Table')
 
@@ -76,46 +75,45 @@ end
 
 ---Template:league standings start
 ---@param frame Frame
+---@return string
 function StandingTableLegacyFfa.slotStart(frame)
 	local args = Arguments.getArgs(frame)
-	Variables.varDefine('standings_legacy_start', Json.stringify(args))
-	Variables.varDefine('standings_legacy_count', 0)
+	args.__source = 'legacy_start'
+	return Template.stashReturnValue(args, 'standings_legacy')
 end
 
 ---Template:league standings slot & Template:league standings slot2
 ---@param frame Frame
+---@return string
 function StandingTableLegacyFfa.slot(frame)
 	local args = Arguments.getArgs(frame)
-	local cnt = (tonumber(Variables.varDefault('standings_legacy_count')) or 0) + 1
-	Variables.varDefine('standings_legacy_slot_' .. cnt, Json.stringify(args))
-	Variables.varDefine('standings_legacy_count', cnt)
+	args.__source = 'legacy_slot'
+	return Template.stashReturnValue(args, 'standings_legacy')
 end
 
 ---Template:league standings end & Template:league standings end2
 ---@param frame Frame
 ---@return Renderable?
 function StandingTableLegacyFfa.templateEnd(frame)
-	local cnt = tonumber(Variables.varDefault('standings_legacy_count'))
-	if not cnt then
+	local entries = Template.retrieveReturnValues('standings_legacy')
+
+	if #entries == 0 then
 		return
 	end
-	local startArgs = Json.parseIfString(Variables.varDefault('standings_legacy_start'))
-	if not startArgs then
-		return
+
+	local startArgs = table.remove(entries, 1)
+
+	if startArgs.__source ~= 'legacy_start' then
+		mw.ext.TeamLiquidIntegration.add_category('Pages with malformed Legacy FFA standings structure')
+		error('Invalid legacy FFA Standings setup')
 	end
-	Variables.varDefine('standings_legacy_start', nil)
-	local slots = Array.mapRange(1, cnt, function(index)
-		local data = (Json.parseIfString(Variables.varDefault('standings_legacy_slot_' .. index)))
-		Variables.varDefine('standings_legacy_slot_' .. index, nil)
-		return data
-	end)
 
 	local rounds = Table.map(Array.range(1, tonumber(startArgs.rounds) or 1), function(roundIndex)
 		return 'round' .. roundIndex, StandingTableLegacyFfa.parseRoundInput(startArgs, roundIndex)
 	end)
 
 	---@type StandingTableOpponentData[]
-	local opponents = Array.map(slots, function(slot)
+	local opponents = Array.map(entries, function(slot)
 		return StandingTableLegacyFfa.parseTeamInputManualSlots(slot)
 	end)