fix(cli): restore fallback for unknown kernel language/type in kernels_pull#1091
Merged
Merged
Conversation
stevemessick
reviewed
Jul 7, 2026
|
|
||
| # Verify file write | ||
| mock_open_file.assert_called_once_with("/tmp/dummy/my-slug.py", "w", encoding="utf-8") | ||
| mock_open_file.assert_called_once_with(os.path.join("/tmp/dummy", "my-slug.py"), "w", encoding="utf-8") |
Contributor
There was a problem hiding this comment.
I don't understand why one slash was changed to use join instead but two others left in place.
Contributor
Author
There was a problem hiding this comment.
Done, I've reverted the existing path assertions back to their original form to keep this PR focused on the fallback fix.
| @patch("os.path.isfile", return_value=False) | ||
| @patch("builtins.open", new_callable=mock_open) | ||
| @patch.object(KaggleApi, "build_kaggle_client") | ||
| def test_kernels_pull_supported_julia_script(self, mock_client, mock_open_file, mock_isfile, mock_exists): |
Contributor
There was a problem hiding this comment.
julia is no longer supported, but we haven't cleaned up all the references yet.
Contributor
Author
There was a problem hiding this comment.
Fixed. I've removed the Julia test along with other duplicate supported language tests to refine the PR's scope.
Contributor
|
/gcbrun |
sridipbasu
force-pushed
the
fix/kernels-pull-fallback
branch
from
355963c to
4ef4aea
Compare
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug in
kernels_pullwhere the existing fallback for unknown kernel language/type combinations was never reached.If the language/type doesn't match one of the known extension mappings,
extensionremainsNone. The code then attempts to build the filename using:which raises a
TypeErrorbefore the fallback logic can execute.Fix
Instead of concatenating immediately, the code now checks whether an extension was resolved first. If not, it allows the existing fallback to handle the case and use
script.py.This doesn't change the behavior for any of the currently supported language/type mappings.
Tests
Added regression tests covering:
Also verified that existing mappings continue to work correctly for supported kernel types.
Validation
pytest tests/unitblack --check .mypy src/kaggle tests