Repository navigation
Fix contraction constant in inv for interval matrices - #793
Merged
Merged
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
==========================================
- Coverage 94.66% 88.41% -6.26%
==========================================
Files 33 33
Lines 3376 3350 -26
==========================================
- Hits 3196 2962 -234
- Misses 180 388 +208 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks for reporting this issue. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inv uses the right residual F = A * approx_A⁻¹ - I. Then E = A⁻¹ - approx_A⁻¹ satisfies E = -approx_A⁻¹ * F - E * F, so the contraction constant must be the largest column sum opnorm(F, 1), not the largest row sum opnorm(F, Inf). With the row sum the enclosure can miss the true inverse:
This PR uses opnorm(F, 1) and adds this example as a test.