Skip to content

Commit 916bbee

Browse files
committed
chore: fix lints
1 parent b6ed999 commit 916bbee

3 files changed

Lines changed: 9 additions & 17 deletions

File tree

src/ui/components/issue_conversation.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ use rat_widget::{
2020
use ratatui::{
2121
buffer::Buffer,
2222
layout::{Rect, Spacing},
23-
style::{Color, Modifier, Style, Stylize},
23+
style::{Color, Modifier, Style},
2424
text::{Line, Span, Text},
2525
widgets::{self, Block, Borders, ListItem, Padding, StatefulWidget, Widget},
2626
};
27-
use ratatui_macros::{horizontal, line, span, vertical};
27+
use ratatui_macros::{horizontal, line, vertical};
2828
use std::{
2929
collections::{HashMap, HashSet},
3030
sync::{Arc, OnceLock, RwLock},
@@ -367,7 +367,7 @@ impl IssueConversation {
367367
self.current.as_ref().map(|s| s.number).unwrap_or_default()
368368
));
369369
let title = title.trim();
370-
let wrapped_title = wrap(&title, area.main_content.width.saturating_sub(2) as usize);
370+
let wrapped_title = wrap(title, area.main_content.width.saturating_sub(2) as usize);
371371
let title_para_height = wrapped_title.len() as u16 + 1;
372372
let title_para = Text::from_iter(wrapped_title);
373373

src/ui/components/issue_convo_preview.rs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,14 @@ use ratatui::{
99
layout::Rect,
1010
widgets::{Block, Borders, StatefulWidget, Widget},
1111
};
12-
use std::sync::{Arc, RwLock};
12+
use std::sync::Arc;
1313
use textwrap::wrap;
1414

1515
use crate::{
1616
errors::AppError,
1717
ui::{
1818
Action,
1919
components::{Component, help::HelpElementKind, issue_conversation::render_markdown},
20-
issue_data::{IssueId, UiIssuePool},
2120
layout::Layout,
2221
utils::get_border_style,
2322
},
@@ -40,27 +39,19 @@ pub const HELP: &[HelpElementKind] = &[
4039
crate::help_keybind!("Esc", "exit fullscreen / return to issue list"),
4140
];
4241

42+
#[derive(Default)]
4343
pub struct IssueConvoPreview {
4444
action_tx: Option<tokio::sync::mpsc::Sender<Action>>,
4545
body: Option<Arc<str>>,
4646
area: Rect,
47-
current: Option<IssueId>,
4847
paragraph_state: ParagraphState,
4948
index: usize,
5049
focus: FocusFlag,
5150
}
5251

5352
impl IssueConvoPreview {
5453
pub fn new() -> Self {
55-
Self {
56-
action_tx: None,
57-
current: None,
58-
body: None,
59-
index: 0,
60-
focus: FocusFlag::default(),
61-
area: Rect::default(),
62-
paragraph_state: ParagraphState::default(),
63-
}
54+
Self::default()
6455
}
6556

6657
pub fn render(&mut self, area: Layout, buf: &mut Buffer) {
@@ -81,7 +72,7 @@ impl IssueConvoPreview {
8172
return;
8273
};
8374
let body_str = wrap(
84-
&body,
75+
body,
8576
area.mini_convo_preview.width.saturating_sub(2) as usize,
8677
)
8778
.join("\n");

src/ui/components/issue_list.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#![allow(clippy::await_holding_lock)]
12
use crate::{
23
app::GITHUB_CLIENT,
34
bookmarks::Bookmarks,
@@ -1162,7 +1163,7 @@ impl Component for IssueList<'_> {
11621163
}
11631164
let (issue_number, labels, preview_seed) = {
11641165
let pool = self.issue_pool.read().expect("issue pool lock poisoned");
1165-
let issue = pool.get_issue(self.issues[selected].0);
1166+
let issue = { pool.get_issue(self.issues[selected].0) };
11661167
if let Some(body_id) = issue.body {
11671168
let body = pool.resolve_str(body_id);
11681169
self.action_tx

0 commit comments

Comments
 (0)