fix: review + badge

Author: jharlow-intel

.github/workflows/coverity.yml

@@ -13,16 +13,12 @@ name: Coverity Scan
 #        COVERITY_SCAN_EMAIL  - a maintainer email for build notifications
 #
 # Free-tier quota for a project under 100K LOC (mkl_random is ~10K) is 28
-# builds/week, max 4/day. This scans every push to master; the concurrency
-# group below cancels a superseded in-progress scan, so a burst of merges
-# collapses toward a single upload and stays within quota. The weekly cron is
-# a safety net for weeks with no commits to master.
+# builds/week, max 4/day, so this runs on a weekly schedule plus on demand
+# rather than per-push.
 
 on:
-  push:
-    branches: [master]
   schedule:
-    - cron: "0 1 * * 1"  # weekly safety net; well under the free build quota
+    - cron: "0 1 * * 1"  # Mondays 01:00 UTC; well under the free build quota
   workflow_dispatch:
 
 permissions:
@@ -34,7 +30,6 @@ concurrency:
 
 env:
   COVERITY_PROJECT: IntelPython/mkl_random
-  ONEAPI_ROOT: /opt/intel/oneapi
 
 jobs:
   coverity-scan:
@@ -55,28 +50,28 @@ jobs:
           architecture: x64
 
       - name: Install build dependencies
-        run: pip install cython "setuptools>=77" "numpy>=2"
-
-      - name: Add Intel repository
-        run: |
-          wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB
-          sudo apt-key add GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB
-          rm GPG-PUB-KEY-INTEL-SW-PRODUCTS-2023.PUB
-          sudo add-apt-repository "deb https://apt.repos.intel.com/oneapi all main"
-          sudo apt-get update
-
-      - name: Install Intel MKL
-        run: sudo apt-get install -y intel-oneapi-mkl-devel
+        run: pip install cython "setuptools>=77" "numpy>=2" mkl-devel
 
       - name: Export MKLROOT
         run: |
-          source "${ONEAPI_ROOT}/setvars.sh"
-          if [ -z "${MKLROOT:-}" ]; then
-            echo "::error::MKLROOT was not set after sourcing setvars.sh"
+          # mkl-devel installs mkl.h + libmkl_rt into the Python prefix.
+          MKLROOT="$(python -c 'import sys; print(sys.prefix)')"
+          if [ ! -f "${MKLROOT}/include/mkl.h" ]; then
+            echo "::error::mkl.h not found under ${MKLROOT}; mkl-devel did not install as expected."
             exit 1
           fi
+          # The wheel ships only the versioned libmkl_rt.so.3, not the bare
+          # linker name, so `g++ -lmkl_rt` fails until we add the symlink.
+          if [ ! -e "${MKLROOT}/lib/libmkl_rt.so" ]; then
+            rt_so=("${MKLROOT}/lib/"libmkl_rt.so.*)
+            if [ ! -e "${rt_so[0]}" ]; then
+              echo "::error::libmkl_rt.so.* not found under ${MKLROOT}/lib."
+              exit 1
+            fi
+            ln -s "${rt_so[0]}" "${MKLROOT}/lib/libmkl_rt.so"
+          fi
           echo "MKLROOT=${MKLROOT}" >> "$GITHUB_ENV"
-          echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}" >> "$GITHUB_ENV"
+          echo "LD_LIBRARY_PATH=${MKLROOT}/lib:${LD_LIBRARY_PATH}" >> "$GITHUB_ENV"
 
       - name: Download Coverity Build Tool
         env:

README.md

@@ -1,5 +1,6 @@
 ## `mkl_random` -- a NumPy-based Python interface to Intel® oneAPI Math Kernel Library (OneMKL) Random Number Generation functionality
 [![Conda package using conda-forge](https://github.com/IntelPython/mkl_random/actions/workflows/conda-package-cf.yml/badge.svg)](https://github.com/IntelPython/mkl_random/actions/workflows/conda-package-cf.yml)
+[![Coverity Scan Build Status](https://scan.coverity.com/projects/33198/badge.svg)](https://scan.coverity.com/projects/intelpython-mkl_random)
 
 `mkl_random` started as a part of Intel® Distribution for Python optimizations to NumPy.