Skip to content

fix(action-strip): update ContentChildren decorator for actionButtons property - master #16844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IMinchev64 wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −3
Open

fix(action-strip): update ContentChildren decorator for actionButtons property - master #16844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2989ab7
fix(action-strip): update ContentChildren decorator for actionButtons…
IMinchev64 Feb 2, 2026
dac3a68
test(elements): add test for actionButtons content query population
IMinchev64 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion projects/igniteui-angular-elements/src/analyzer/elements.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,13 @@ export var registerConfig = [
IgxHierarchicalGridComponent,
IgxRowIslandComponent,
],
contentQueries: [],
contentQueries: [
{
property: "actionButtons",
childType: IgxActionStripActionsToken,
isQueryList: true,
},
],
additionalProperties: [{ name: "cdr", writable: true }],
methods: ["show", "hide"],
boolProps: ["hidden"],
Expand Down
19 changes: 18 additions & 1 deletion projects/igniteui-angular-elements/src/app/custom-strategy.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IgxColumnComponent, IgxGridComponent, IgxHierarchicalGridComponent } from 'igniteui-angular';
import { IgxActionStripComponent, IgxColumnComponent, IgxGridComponent, IgxHierarchicalGridComponent } from 'igniteui-angular';
import { html } from 'lit';
import { firstValueFrom, fromEvent, skip, timer } from 'rxjs';
import { ComponentRefKey, IgcNgElement } from './custom-strategy';
Expand Down Expand Up @@ -235,6 +235,23 @@ describe('Elements: ', () => {
expect(grid.getColumnByVisibleIndex(1).field).toEqual('ProductName');
});

it('should populate action strip actionButtons content query.', async () => {
const innerHtml = `
<igc-grid id="testGrid" auto-generate>
<igc-action-strip id="testStrip">
<igc-grid-editing-actions add-row="true"></igc-grid-editing-actions>
</igc-action-strip>
</igc-grid>`;
testContainer.innerHTML = innerHtml;

// TODO: Better way to wait - potentially expose the queue or observable for update on the strategy
await firstValueFrom(timer(10 /* SCHEDULE_DELAY */ * 3));

const actionStrip = document.querySelector<IgcNgElement>('#testStrip');
const actionStripComponent = (await actionStrip.ngElementStrategy[ComponentRefKey]).instance as IgxActionStripComponent;
expect(actionStripComponent.actionButtons.toArray().length).toBeGreaterThan(0);
});

it('should not destroy action strip when row it is shown in is destroyed or cached.', async() => {
const innerHtml = `
<igc-grid id="testGrid" auto-generate>
Expand Down
2 changes: 1 addition & 1 deletion projects/igniteui-angular/action-strip/src/action-strip/action-strip.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export class IgxActionStripComponent implements IgxActionStripToken, AfterViewIn
* @hidden
* @internal
*/
@ContentChildren(IgxActionStripActionsToken as any)
@ContentChildren(IgxActionStripActionsToken)
public actionButtons: QueryList<IgxActionStripActionsToken>;

/**
Expand Down
Loading