When there is a guestbook, you cannot download files using a Preview URL

[leligdon]

When a guestbook is enabled, there is an error when trying to download files using a preview URL.

What steps does it take to reproduce the issue?

Create an unpublished dataset with a guestbook enabled at the collection level.
Add both restricted and unrestricted files to the dataset.
Create a Preview URL for the dataset.
Open the Preview URL in a logged out/anonymous browser session.
Attempt to download any file (restricted or unrestricted).

What happens?
The download fails with the following error, regardless of file type:
{"status":"ERROR","message":"You may not download this file without the required Guestbook response for guestbookID 60."}

The guestbook popup does not appear to collect a response before the download attempt is made. Disabling the guestbook on the dataset resolves the issue and files download normally through the Preview URL.

Which version of Dataverse are you using?
v6.11

To whom does it occur (all users, curators, superusers)?
Occurs for anonymous/logged out users accessing files via Preview URL. Users with existing Curator/Admin permissions on the dataset do not encounter the error, since their access is granted through their account role rather than the Preview URL token, making this hard to reproduce with elevated permissions.

What did you expect to happen?
Either the guestbook form should be presented and its response collected before the download proceeds, or Preview URL access should be documented as incompatible with guestbooks if that is the intended behavior.

[pdurbin]

@leligdon thank you very much for alerting us to this problem first in a thread on the mailing list and now in this issue!

I was able to reproduce the issue using some test code I wrote in bd94466 to do the setup. Here are the steps:

• Create a guestbook
• Create a dataset and upload some files
• Associate the dataset with the guestbook
• Create a Private URL in the dataset
• In an incognito window, open the Private URL and try to download files
• Observe that the files cannot be downloaded. Instead, the reviewer (or whoever is using the Private URL) gets an error like You may not download this file without the required Guestbook response for guestbookID [number]. Here's a screenshot:

This is a regression introduced by the following pull request in Dataverse 6.10:

• Feature Request: API to support Download Terms of Use and Guestbook #12110

@jggautier and I believe that the previous behavior in Dataverse 6.9 and lower was that the reviewer (the person using the Private URL) was able to download the file freely without having to fill in a guestbook. We think this behavior should be restored.