fix(dictation): initialize non-zero session ID and filter stale session 0 messages

Ensure the first dictation session in a process gets stale-message protection by initializing sessionID to 1 in newDictationController and removing msg.sessionID != 0 exemptions in handleDictationTranscribed and handleDictationPartial. Clean up unreachable redaction guards in providerio.

Refs #710

Author: euxaristia

internal/providers/providerio/providerio.go

@@ -422,7 +422,7 @@ func looksLikeToken(w string) bool {
 // Redact removes known API-key and bearer-token forms from provider messages.
 func Redact(message string, secrets ...string) string {
 	for _, secret := range secrets {
-		if secret != "" && !strings.HasPrefix(secret, "[REDACTED") {
+		if secret != "" {
 			message = strings.ReplaceAll(message, secret, "[REDACTED]")
 		}
 	}
@@ -432,7 +432,7 @@ func Redact(message string, secrets ...string) string {
 			strings.EqualFold(strings.TrimRight(words[index], ":"), "Token") ||
 			strings.EqualFold(strings.TrimRight(words[index], ":"), "X-Api-Key") ||
 			strings.EqualFold(strings.TrimRight(words[index], ":"), "api-key")
-		if hdr && !strings.HasPrefix(words[index+1], "[REDACTED") && looksLikeToken(words[index+1]) {
+		if hdr && looksLikeToken(words[index+1]) {
 			words[index+1] = "[REDACTED]"
 		}
 	}

internal/tui/dictation.go

@@ -127,6 +127,7 @@ func newDictationController(opts Options) dictationController {
 		platform:       dictation.DetectPlatform(),
 		downloadRoot:   opts.STTDownloadRoot,
 		userConfigPath: opts.UserConfigPath,
+		sessionID:      1,
 	}
 }
 
@@ -378,7 +379,7 @@ func (m model) handleDictationStarted(msg dictationStartedMsg) (model, tea.Cmd)
 // handleDictationTranscribed inserts the final transcript into the composer (or
 // submits it when stt.autoSubmit is on), then returns to idle.
 func (m model) handleDictationTranscribed(msg dictationTranscribedMsg) (tea.Model, tea.Cmd) {
-	if msg.sessionID != 0 && msg.sessionID != m.dictation.sessionID {
+	if msg.sessionID != m.dictation.sessionID {
 		return m, nil
 	}
 	streaming := m.dictation.streaming || msg.streaming

internal/tui/dictation_stream.go

@@ -79,7 +79,7 @@ func (m model) startStreamingDictation() (model, tea.Cmd) {
 // composer, replacing the previously-rendered live region wholesale so the text
 // builds up in place as the user keeps talking.
 func (m model) handleDictationPartial(msg sttPartialMsg) model {
-	if msg.sessionID != 0 && msg.sessionID != m.dictation.sessionID {
+	if msg.sessionID != m.dictation.sessionID {
 		return m
 	}
 	// Ignore stragglers that arrive after the session ended (cancel/final).

internal/tui/dictation_test.go

@@ -353,6 +353,16 @@ func TestStaleDictationCompletionIgnoredAfterCancel(t *testing.T) {
 		t.Fatalf("composer text = %q, want 'original composer text'", m.composer.text)
 	}
 
+	// Stale partial message from session 1 must be ignored
+	stalePartial := sttPartialMsg{
+		sessionID: 1,
+		text:      "stale partial that should be ignored",
+	}
+	mPartial := m.handleDictationPartial(stalePartial)
+	if mPartial.composer.text != "original composer text" {
+		t.Fatalf("composer text changed to %q after stale partial", mPartial.composer.text)
+	}
+
 	staleMsg := dictationTranscribedMsg{
 		sessionID: 1,
 		text:      "stale text that should be ignored",
@@ -369,3 +379,44 @@ func TestStaleDictationCompletionIgnoredAfterCancel(t *testing.T) {
 		t.Fatalf("expected no command for stale completion, got %v", cmd)
 	}
 }
+
+func TestStaleDictationSessionZeroIgnoredAfterCancel(t *testing.T) {
+	m := model{}
+	m.setComposerState(composerState{text: "initial composer text", cursor: 21})
+	m.dictation.sessionID = 0
+	m.dictation.phase = dictRecording
+
+	m, _ = m.cancelDictation()
+
+	// Session 0 was reset to session 1
+	if m.dictation.sessionID != 1 {
+		t.Fatalf("dictation.sessionID = %d after cancel, want 1", m.dictation.sessionID)
+	}
+
+	// Stale partial from session 0 must be ignored
+	stalePartial := sttPartialMsg{
+		sessionID: 0,
+		text:      "stale partial from session 0",
+	}
+	mPartial := m.handleDictationPartial(stalePartial)
+	if mPartial.composer.text != "initial composer text" {
+		t.Fatalf("composer text changed to %q after stale session 0 partial", mPartial.composer.text)
+	}
+
+	// Stale completion from session 0 must be ignored
+	staleMsg := dictationTranscribedMsg{
+		sessionID: 0,
+		text:      "stale completion from session 0",
+		submit:    true,
+		streaming: true,
+	}
+	afterStale, cmd := m.handleDictationTranscribed(staleMsg)
+	got := afterStale.(model)
+
+	if got.composer.text != "initial composer text" {
+		t.Fatalf("composer text changed to %q after stale session 0 completion", got.composer.text)
+	}
+	if cmd != nil {
+		t.Fatalf("expected no command for stale session 0 completion, got %v", cmd)
+	}
+}