Skip to content

Commit f52f336

Browse files
committed
fix: unify macos packaging between local and release
1 parent 9d16149 commit f52f336

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ jobs:
6767
- release_platform: macos
6868
runner: macos-latest
6969
tauri_target: universal-apple-darwin
70-
bundles: app,dmg
70+
bundles: app
7171
sidecar_script: scripts/desktop/build_sidecar_macos.sh
7272
artifact_name: release-assets-macos
7373
rust_targets: aarch64-apple-darwin,x86_64-apple-darwin

scripts/desktop/package_local_release.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,17 @@ bash "$ROOT_DIR/scripts/release/sync_release_metadata.sh" "${sync_args[@]}"
4242
case "$TARGET_PLATFORM" in
4343
macos)
4444
bash "$ROOT_DIR/scripts/desktop/build_sidecar_macos.sh"
45+
npm --prefix desktop run tauri build -- --bundles app
4546
;;
4647
windows)
4748
bash "$ROOT_DIR/scripts/desktop/build_sidecar_windows.sh"
49+
npm --prefix desktop run tauri build
4850
;;
4951
*)
5052
echo "Unsupported release platform: $TARGET_PLATFORM" >&2
5153
exit 1
5254
;;
5355
esac
54-
55-
npm --prefix desktop run tauri build
5656
bash "$ROOT_DIR/scripts/desktop/notarize_macos.sh"
5757

5858
collect_env=(RELEASE_VERSION="$TAG" RELEASE_ASSET_DIR="$ASSET_DIR")

scripts/test/package_local_release_test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ chmod +x "$repo_dir/bin/npm"
9191
assert_file "$tmp_dir/release-assets/artifact.txt"
9292
assert_contains "$tmp_dir/calls.log" "sync:--tag v2.3.4"
9393
assert_contains "$tmp_dir/calls.log" "sidecar:macos"
94-
assert_contains "$tmp_dir/calls.log" "npm:--prefix desktop run tauri build"
94+
assert_contains "$tmp_dir/calls.log" "npm:--prefix desktop run tauri build -- --bundles app"
9595
assert_contains "$tmp_dir/calls.log" "notarize"
9696
assert_contains "$tmp_dir/calls.log" "collect:v2.3.4"
9797

0 commit comments

Comments
 (0)