Skip to content

Commit 4f10d2a

Browse files
author
Camille Croci
committed
fix: from copilot code review
Remove useless import Check in unit tests that the systemCode is actually in the event
1 parent 1512b46 commit 4f10d2a

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

core/cli/src/install.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { findConflicts, withoutConflicts } from '@dotcom-tool-kit/conflict'
1414
import { formatUninstalledHooks } from './messages'
1515
import { importEntryPoint } from './plugin/entry-point'
1616
import { runInit } from './init'
17-
import { guessSystemCode } from './systemCode'
1817
import { enableTelemetry } from './telemetry'
1918
import { TelemetryRecorder } from '@dotcom-tool-kit/telemetry'
2019

lib/telemetry/test/index.test.ts

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,14 @@ describe('metrics sent', () => {
179179
const listeningPromise = listenForTelemetry(mockServer, 1)
180180
telemetryProcess.root().recordEvent('tasks.completed', 'mock-system-code', { success: true })
181181
const metrics = await listeningPromise
182-
expect(metrics).toEqual([[expect.objectContaining({ namespace: 'dotcom-tool-kit.tasks.completed' })]])
182+
expect(metrics).toEqual([
183+
[
184+
expect.objectContaining({
185+
namespace: 'dotcom-tool-kit.tasks.completed',
186+
systemCode: 'mock-system-code'
187+
})
188+
]
189+
])
183190
})
184191

185192
// TODO:IM:20260107 enable this test once we have multiple different metric types
@@ -190,8 +197,14 @@ describe('metrics sent', () => {
190197
recorder.recordEvent('tasks.completed', 'mock-system-code', { success: true })
191198
const metrics = await listeningPromise
192199
expect(metrics.flat()).toEqual([
193-
expect.objectContaining({ namespace: 'dotcom-tool-kit.tasks.completed' }),
194-
expect.objectContaining({ namespace: 'dotcom-tool-kit.tasks.completed' })
200+
expect.objectContaining({
201+
namespace: 'dotcom-tool-kit.tasks.completed',
202+
systemCode: 'mock-system-code'
203+
}),
204+
expect.objectContaining({
205+
namespace: 'dotcom-tool-kit.tasks.completed',
206+
systemCode: 'mock-system-code'
207+
})
195208
])
196209
})
197210

0 commit comments

Comments
 (0)