bug: getMetadata casts untrusted IPFS gateway JSON to TokenMetadata without validation

[Ejirowebfi]

Summary

IPFSService.getMetadata casts an arbitrary gateway JSON response straight to TokenMetadata with no runtime shape validation.

Evidence

frontend/src/services/ipfs.ts:97-101

try {
  return (await response.json()) as TokenMetadata
} catch {
  throw new IPFSUploadError('Metadata response is not valid JSON.')
}

The content behind an ipfs:// URI is user/third-party controlled. The returned name/description/image are then consumed by UI components. A missing/malformed image field (or unexpected types) flows downstream untyped, and the as cast gives a false sense of safety.

Suggested fix

Validate the parsed object against the TokenMetadata shape (e.g. a small guard or zod schema) before returning; reject or sanitize unexpected fields. Ensure consumers treat image defensively.

[matieuu1]

blindly casting user-controlled IPFS gateway responses to TokenMetadata with no shape validation, so malformed image fields and missing properties flow downstream untyped. I'll add a Zod schema to validate the response shape before returning, and ensure consumers handle missing/malformed fields defensively.

[zeekman]

I build production software with a focus on correct, predictable data handling, including blockchain applications on the Stellar Network where storage and state management are central. I'm comfortable with authorization logic and compliance-driven features where correctness and auditability matter, and I work the open-source way, tests, clean PRs, and respecting existing conventions.

[Oluwasuyi-Timilehin]

Hello maintainers I'm a full stack developer experience in building scalable systems I can handle this perfectly if assigned

[grantfox-oss]

🦊 GrantFox — @zeekman has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #849)
2. Your PR will be reviewed by the Favourorg maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign campaign!

@zeekman's PR #877 was approved and merged by @Ejirowebfi.

🏆 @zeekman: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (296 total points). Track your full progress on GrantFox.

👏 Great work, @zeekman! Keep contributing to Favourorg.