Skip to content

Commit 0ac44fe

Browse files
committed
Review cheer for no AUF
1 parent 69aa821 commit 0ac44fe

3 files changed

Lines changed: 7 additions & 1 deletion

File tree

term_timer/cheers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,8 @@ def get_auf_cheer(solve: 'Solve') -> str:
193193
Cheer message
194194
195195
"""
196+
if not solve.aufs:
197+
return 'No AUFs - great case mastery.'
196198
if solve.aufs <= 2:
197199
return 'Minimal AUFs - great prediction.'
198200
return ''

term_timer/tests/test_cheers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ def test_zero_aufs(self) -> None:
657657
solve = Mock()
658658
solve.aufs = 0
659659
result = get_auf_cheer(solve)
660-
self.assertEqual(result, 'Minimal AUFs - great prediction.')
660+
self.assertEqual(result, 'No AUFs - great case mastery.')
661661

662662
def test_one_auf(self) -> None:
663663
"""Test cheer for one AUF."""

term_timer/tests/test_stats.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,7 @@ def test_detail_advanced_solve_full_display(self) -> None:
427427
"""Test detail method with advanced solve showing all features."""
428428
# Create comprehensive mock advanced solve
429429
mock_solve = Mock(spec=Solve)
430+
mock_solve.solve_id = 42
430431
mock_solve.final_time = 15 * SECOND
431432
mock_solve.time = 15 * SECOND
432433
mock_solve.advanced = True
@@ -523,6 +524,7 @@ def test_detail_advanced_solve_conditional_aufs(self) -> None:
523524
for aufs_count, _expected_style in test_cases:
524525
with self.subTest(aufs_count=aufs_count):
525526
mock_solve = Mock(spec=Solve)
527+
mock_solve.solve_id = 42
526528
mock_solve.final_time = 15 * SECOND
527529
mock_solve.time = 15 * SECOND
528530
mock_solve.advanced = True
@@ -604,6 +606,7 @@ def test_detail_advanced_solve_conditional_aufs(self) -> None:
604606
def test_detail_with_reconstruction_display(self) -> None:
605607
"""Test detail method with reconstruction display."""
606608
mock_solve = Mock(spec=Solve)
609+
mock_solve.solve_id = 42
607610
mock_solve.final_time = 15 * SECOND
608611
mock_solve.time = 15 * SECOND
609612
mock_solve.advanced = True
@@ -687,6 +690,7 @@ def test_detail_with_reconstruction_display(self) -> None:
687690
def test_detail_with_graphs() -> None:
688691
"""Test detail method with graph displays."""
689692
mock_solve = Mock(spec=Solve)
693+
mock_solve.solve_id = 42
690694
mock_solve.final_time = 15 * SECOND
691695
mock_solve.time = 15 * SECOND
692696
mock_solve.advanced = True

0 commit comments

Comments
 (0)