Skip to content

yang: Swapped RPF lookup mode descriptions#22375

Merged
Jafaral merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-Ver17
Jun 22, 2026
Merged

yang: Swapped RPF lookup mode descriptions#22375
Jafaral merged 1 commit into
FRRouting:masterfrom
y-bharath14:srib-yang-Ver17

Conversation

@y-bharath14

Copy link
Copy Markdown
Contributor

Swapped RPF lookup mode descriptions
Corrected inconsistent boolean defaults in the module

Swapped RPF lookup mode descriptions
Corrected inconsistent boolean defaults in the module

Signed-off-by: y-bharath14 <y.bharath@samsung.com>
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes two documentation/schema correctness issues in the FRR PIM YANG module. The descriptions for the mrib-only and urib-only RPF lookup mode enumerations were swapped, causing the model to self-contradict — mrib-only claimed to look up in the unicast RIB and vice versa. Additionally, three boolean default statements used bare false instead of the quoted "false" form used everywhere else in the file.

  • RPF description swap: mrib-only (value 1) now correctly reads "Lookup in multicast RIB only." and urib-only (value 2) now correctly reads "Lookup in unicast RIB only.", matching both the enum names and the pim_rpf_lookup_mode C enum in pimd/pim_rpf.h.
  • Boolean defaults: Three default false statements in the MSDP leaf nodes are updated to default "false", consistent with all other boolean defaults in the file.

Confidence Score: 5/5

Safe to merge — both changes are pure documentation/schema corrections with no behavioral impact at runtime.

The enum name-to-description mismatch is clearly a copy-paste error confirmed by the C enum in pimd/pim_rpf.h; the fix is unambiguous. The boolean default quoting change is cosmetic and consistent with every other boolean default in the file. Neither change affects compiled code or runtime behavior.

No files require special attention.

Important Files Changed

Filename Overview
yang/frr-pim.yang Swaps swapped enum descriptions for mrib-only/urib-only RPF lookup modes and quotes three bare boolean default values for consistency.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[RPF Lookup Request] --> B{mcast-rpf-lookup-mode}
    B -->|none - value 0| C[No mode set]
    B -->|mrib-only - value 1| D["Lookup in multicast RIB only - Fixed"]
    B -->|urib-only - value 2| E["Lookup in unicast RIB only - Fixed"]
    B -->|mrib-then-urib - value 3| F[Try mcast RIB first, fall back to unicast RIB]
    B -->|lower-distance - value 4| G[Use entry with lower distance]
    B -->|longer-prefix - value 5| H[Use entry with longer prefix]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[RPF Lookup Request] --> B{mcast-rpf-lookup-mode}
    B -->|none - value 0| C[No mode set]
    B -->|mrib-only - value 1| D["Lookup in multicast RIB only - Fixed"]
    B -->|urib-only - value 2| E["Lookup in unicast RIB only - Fixed"]
    B -->|mrib-then-urib - value 3| F[Try mcast RIB first, fall back to unicast RIB]
    B -->|lower-distance - value 4| G[Use entry with lower distance]
    B -->|longer-prefix - value 5| H[Use entry with longer prefix]
Loading

Reviews (1): Last reviewed commit: "yang: Swapped RPF lookup mode descriptio..." | Re-trigger Greptile

@y-bharath14

Copy link
Copy Markdown
Contributor Author

ci:rerun

@mergify

mergify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@Jafaral

Jafaral commented Jun 22, 2026

Copy link
Copy Markdown
Member

@Mergifyio backport stable/10.7

@mergify

mergify Bot commented Jun 22, 2026

Copy link
Copy Markdown

backport stable/10.7

✅ Backports have been created

Details

@Jafaral Jafaral merged commit 6eacd0f into FRRouting:master Jun 22, 2026
36 of 37 checks passed
Jafaral added a commit that referenced this pull request Jun 22, 2026
yang: Swapped RPF lookup mode descriptions (backport #22375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants