Skip to content

Commit 560fb80

Browse files
gloryfromcazhanghuiclaude
authored
docs(lancedb): mark the husk sweep removable once lance#8322 ships (#399)
Upstream merged the fix on 2026-08-06: cleanup now removes the directories it empties, under the same 7-day / delete_unverified policy this sweep reimplements. It is not in any release yet (lancedb 0.34.0 embeds lance 8.0.0; the merge sits ahead of v11.0.0-beta.2), so the sweep stays -- but the next pin carrying it should delete this rather than keep a second copy of upstream's rule. That upgrade also collapses the documented horizon from ~14 days to ~7: lance drops the directory in the same pass that empties it, so our age gate stops stacking on top of theirs. Co-authored-by: zhanghui <zhanghui@shanda.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 9d48544 commit 560fb80

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎src/everos/core/persistence/lancedb/repository.py‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,16 @@
103103
ext4 has a fixed inode budget at all; APFS and xfs allocate dynamically, and
104104
Windows is out of scope. The knob to reach for if this ever does bite is the
105105
optimize cooldown, not this threshold — see there.
106+
107+
**When to remove this sweep** — lance-format/lance#8322 (merged 2026-08-06,
108+
not in any release as of lancedb 0.34.0 / lance 8.0.0 — the merge sits ahead of
109+
v11.0.0-beta.2) makes lance's own cleanup remove the directories it empties,
110+
under this same 7-day / ``delete_unverified`` policy. Once a release carrying
111+
it is pinned, delete :func:`_remove_empty_index_dirs` and its call site rather
112+
than keep a second implementation of upstream's rule. That upgrade also halves
113+
the horizon above: lance drops the directory in the pass that empties it, so
114+
our age gate stops stacking on top of theirs and the steady state goes from
115+
~14 days back to ~7.
106116
"""
107117

108118
_HUSK_SWEEP_TIMEOUT_SECONDS = 60.0

0 commit comments

Comments
 (0)