Repository navigation
Commit 167473d
test: make the slow/live selection collectable and survivable on Windows
Running `-m "slow or live_llm"` on the Windows box surfaced three problems
in the suite itself, none in the product.
1. `tests/e2e/test_reflection_e2e.py` aborted collection of the whole run
(`ModuleNotFoundError: No module named 'adapters'`), so zero tests
executed. It imported `benchmarks.run` as a package, but since #425 the
runner imports its siblings bare (`import adapters`) and only resolves
with `benchmarks/` itself on sys.path -- the unit tests that use it
already do that dance; this file now mirrors them. Verified against
two detached worktrees: origin/main fails, e8612b9 (v1.3.0, before
#425) collects. Not Windows-specific; CI never collects this file.
The same refactor moved the prompts into `adapters/locomo.py`, added a
`config` parameter to `_build_context`, and a `{current_date_line}`
placeholder to ANSWER_PROMPT; the script body is adapted to those by
signature. It has no `def test_` -- it is a manual driver with a
`test_` filename -- and the adapted body has not been executed here;
that needs a Tier 2 server and a LoCoMo run.
2. `test_real_sigint_during_phase_await_returns_130_with_resume_hint`
sends itself `os.kill(os.getpid(), signal.SIGINT)`. On Windows that
call is TerminateProcess with the signal number as exit code, so the
test killed the pytest process mid-run: 27 of 29 had run, the summary
and every traceback were lost, and `pytest_exit=2` was the literal
SIGINT value, not pytest's "interrupted". Skipped on win32 with the
mechanism in the reason.
3. `test_add_html_file_uri_parsed_into_buffer` built its uri as
`f"file://{doc}"`, which on Windows is `file://C:\...` -- drive letter
in the host slot. Same fix as the unit tests in f7a31c7: `Path.as_uri()`.
Collection of the live selection is now clean (29 selected, 0 errors);
the default `test_backfill_flags.py` selection still passes locally.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>1 parent 9c0fe18 commit 167473d
3 files changed
Lines changed: 35 additions & 18 deletions
File tree
- tests
- e2e
- integration/test_cli
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
36 | 45 | | |
37 | 46 | | |
38 | 47 | | |
| |||
292 | 301 | | |
293 | 302 | | |
294 | 303 | | |
| 304 | + | |
295 | 305 | | |
296 | | - | |
| 306 | + | |
| 307 | + | |
297 | 308 | | |
298 | 309 | | |
299 | 310 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| |||
237 | 238 | | |
238 | 239 | | |
239 | 240 | | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
240 | 246 | | |
241 | 247 | | |
242 | 248 | | |
| |||
0 commit comments