Conversation
963841d to
d287068
Compare
|
evse_replug cmd is still in the EvseBoardSupport interface. Shouldn't we just remove it if no one is using it anymore? |
Yes I guess we will eventually remove it. This PR is still an early draft |
bc8c99d to
b2942cf
Compare
b2942cf to
43905b8
Compare
afed9ab to
3bbc287
Compare
3bbc287 to
ef9d73c
Compare
0bab031 to
b36221e
Compare
6730bb3 to
367254c
Compare
ea171f4 to
9481e08
Compare
Closing the TCP Session and moving to EVSEPaused is the intended here. With the changes in this PR, a call of resume_charging would change from EVSEPaused->PrepareCharging, which would turn on the 5% PWM again, signaling to the EV that a new SLAC and TCP Session can start. |
51a2be2 to
bcc7d75
Compare
barsnick
left a comment
There was a problem hiding this comment.
Looks okay, One comment left @SebaLukas.
8e20b4a to
ed787a5
Compare
…ause/resume and remove replug Remove WaitingForEnergy, Replug states and related session events (ChargingResumed, ReplugStarted, ReplugFinished, WaitingForEnergy). Consolidate pause handling into ChargingPausedEVSE with reason tracking (Error, NoEnergy, UserPause) via new PauseChargingEVSEReasonEnum. Key changes in Charger state machine: - Replace WaitingForEnergy state with direct transitions through ChargingPausedEVSE, which now reports multiple concurrent reasons - Remove evse_replug command from BSP interface and all implementations - Remove EvseReplugStarted/Finished events from board_support_common - Add configurable hlc_charge_loop_without_energy_timeout_s for ISO sessions to handle no-energy scenarios gracefully in charge loop - Add dc_ramp_ampere_per_second config for DC current ramping - Change zero_power_ignore_pause default to true for better EV compatibility - Introduce StoppingCharging as proper transitional state that waits for contactor open before moving to paused or finished states - Use atomic flags (flag_authorized, flag_transaction_active, flag_ev_plugged_in, flag_paused_by_evse) for thread-safe state BREAKING CHANGE: Removes WaitingForEnergy, ChargingResumed, ReplugStarted, ReplugFinished session events and evse_replug BSP command. Consumers must handle ChargingPausedEVSE with reason tracking instead. Smoke tests: - Add pause/resume session commands to test controller interface - Add comprehensive smoke tests for pause/resume and no-energy scenarios - Remove deprecated startup_tests.py in favor of new probe-based tests Signed-off-by: Piet Gömpel <pietgoempel@gmail.com> Signed-off-by: Cornelius Claussen <cc@pionix.de> Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
43e61d9
ed787a5 to
43e61d9
Compare
|
@djchhp @barsnick @hikinggrass @SebaLukas reviews were dismissed due to rebase and a test hash file update, so your approval is required once again |
…ause/resume and remove replug (EVerest#1790) Remove WaitingForEnergy, Replug states and related session events (ChargingResumed, ReplugStarted, ReplugFinished, WaitingForEnergy). Consolidate pause handling into ChargingPausedEVSE with reason tracking (Error, NoEnergy, UserPause) via new PauseChargingEVSEReasonEnum. Key changes in Charger state machine: - Replace WaitingForEnergy state with direct transitions through ChargingPausedEVSE, which now reports multiple concurrent reasons - Remove evse_replug command from BSP interface and all implementations - Remove EvseReplugStarted/Finished events from board_support_common - Add configurable hlc_charge_loop_without_energy_timeout_s for ISO sessions to handle no-energy scenarios gracefully in charge loop - Add dc_ramp_ampere_per_second config for DC current ramping - Change zero_power_ignore_pause default to true for better EV compatibility - Introduce StoppingCharging as proper transitional state that waits for contactor open before moving to paused or finished states - Use atomic flags (flag_authorized, flag_transaction_active, flag_ev_plugged_in, flag_paused_by_evse) for thread-safe state BREAKING CHANGE: Removes WaitingForEnergy, ChargingResumed, ReplugStarted, ReplugFinished session events and evse_replug BSP command. Consumers must handle ChargingPausedEVSE with reason tracking instead. Smoke tests: - Add pause/resume session commands to test controller interface - Add comprehensive smoke tests for pause/resume and no-energy scenarios - Remove deprecated startup_tests.py in favor of new probe-based tests Signed-off-by: Piet Gömpel <pietgoempel@gmail.com> Signed-off-by: Cornelius Claussen <cc@pionix.de> Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de> Co-authored-by: Piet Gömpel <pietgoempel@gmail.com>
Describe your changes
Remove WaitingForEnergy, Replug states and related session events (ChargingResumed, ReplugStarted, ReplugFinished, WaitingForEnergy). Consolidate pause handling into ChargingPausedEVSE with reason tracking
(Error, NoEnergy, UserPause) via new PauseChargingEVSEReasonEnum.
Key changes in Charger state machine:
BREAKING CHANGE: Removes WaitingForEnergy, ChargingResumed, ReplugStarted, ReplugFinished session events and evse_replug BSP command. Consumers must handle ChargingPausedEVSE with reason tracking instead.
Behavioral changes:
zero_power_ignore_pausehas been changed totruebecause this is more compatible with real EVs. With this configuration parameter beingtrueDC sessions will reach the charge loop in case no energy is available before the session is stopped by the EVSE afterhlc_charge_loop_without_energy_timeout_sSmoke tests:
These changes have been verified within the following test scenarios with real EVs for basic charging, ISO15118-2 AC and DC
NOTE: The main changes of this PR are located in
Charger.cpp/hppandEvseManager.cpp/hpp. Most of changes in the other files are due to the removed types, vars and interface commands.Issue ticket number and link
Checklist before requesting a review