GovernanceController parameter updates currently have no effect on target contracts

[dDevAhmed]

• Overview: Rust implementation differs from Solidity logic.
• Complexity: High

[ekwe7]

@ekwe7 has applied to work on this issue as part of the Stellar Wave Program's 4th wave.

I would love to work on this Project

ℹ️ Repo Maintainers: To accept this application, review their application or assign @ekwe7 to this issue.

[snakefood3232]

The issue with GovernanceController not calling setters after parameter updates is critical. I'd handle this by defining an interface and mapping to link ParameterType to respective contract and function selectors, ensuring updates are propagated efficiently. I can have a PR up in two days with a robust solution. I've built similar governance mechanisms for DeFi projects, ensuring proper proposal execution and parameter updates.

[snakefood3232]

I see the core issue is that executeParameterUpdate updates storage but doesn't propagate changes to contracts. I'd handle this by defining an interface and mapping for ParameterType to target contracts and their respective setters to execute the necessary contract calls. Can have a PR up in 3 days. I've built governance execution systems for DeFi protocols before, ensuring seamless parameter updates across multiple contracts.

[snakefood3232]

The issue lies in executeParameterUpdate as it only updates the controller storage values without propagating changes to the protocol contracts. I'd handle this by defining an interface and mapping ParameterType to the target contract and its corresponding setter, ensuring all updates are correctly propagated. Can have a PR up within 3 days to address this. I've built similar governance systems that required robust update mechanisms, so I'm confident in delivering a secure and efficient solution.

[Godbrand0]

@Godbrand0 has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

hello, i can help out with this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Godbrand0 to this issue.

[icodeBisola]

@icodeBisola has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Kindly assign I have ETC of 2-3, confident im the best fit to resolve this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @icodeBisola to this issue.

[od-hunter]

@od-hunter has applied to work on this issue as part of the Stellar Wave Program's 5th wave.

Hi, can i be assigned this issue please? I've gone through the description and I'm up for the task.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @od-hunter to this issue.