Skip to content

feat(skill): create skills asynchronously#1

Merged
DigHuang merged 1 commit into
feat/skill-editfrom
codex/skill-create-detail-loading
May 19, 2026
Merged

feat(skill): create skills asynchronously#1
DigHuang merged 1 commit into
feat/skill-editfrom
codex/skill-create-detail-loading

Conversation

@DigHuang
Copy link
Copy Markdown
Owner

Summary

  • create a visible pending skill immediately and finish package/version setup in a BullMQ worker
  • route create success into the skill detail page and reuse the detail loading state while polling creation status
  • guard non-ready skills from edit/update/save-deploy operations and hide unavailable UI actions

Checks

  • git diff --check
  • pnpm exec eslint packages/global/core/agentSkills/constants.ts packages/global/core/agentSkills/type.ts packages/global/openapi/core/agentSkills/api.ts packages/service/common/bullmq/index.ts packages/service/core/agentSkills/controller.ts packages/service/core/agentSkills/schema.ts packages/service/core/agentSkills/creation.ts
  • pnpm --filter @fastgpt/app exec eslint src/pageComponents/dashboard/skill/CreateSkillModal.tsx src/pageComponents/dashboard/skill/List.tsx src/pageComponents/dashboard/skill/detail/context.tsx src/pageComponents/dashboard/skill/detail/Header.tsx src/pageComponents/dashboard/skill/detail/config/SandboxError.tsx src/pages/dashboard/skill/index.tsx src/pages/api/core/agentSkills/create.ts src/pages/api/core/agentSkills/detail.ts src/pages/api/core/agentSkills/edit.ts src/pages/api/core/agentSkills/list.ts src/pages/api/core/agentSkills/update.ts src/pages/api/core/agentSkills/save-deploy.ts src/service/common/bullmq/index.ts

Note: app eslint reports the existing React Compiler warning for CreateSkillModal watch().

@github-actions
Copy link
Copy Markdown

Coverage Report for global

Status Category Percentage Covered / Total
🔵 Lines 90.63% 2381 / 2627
🔵 Statements 89.76% 2605 / 2902
🔵 Functions 93.31% 447 / 479
🔵 Branches 85.31% 1743 / 2043
File CoverageNo changed files found.
Generated in workflow #1 for commit 77c7e1b by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown

Coverage Report for service

Status Category Percentage Covered / Total
🔵 Lines 46.96% 6576 / 14001
🔵 Statements 46.59% 6992 / 15005
🔵 Functions 44.2% 1340 / 3031
🔵 Branches 42.05% 3873 / 9209
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/service/common/bullmq/index.ts 38.98% 40% 27.27% 37.93% 63-150
packages/service/core/agentSkills/controller.ts 49.03% 40.9% 54.54% 50% 132-145, 169-172, 196, 207-210, 310, 340, 361-473, 480-497
packages/service/core/agentSkills/creation.ts 0% 0% 0% 0% 19-312
Generated in workflow #1 for commit 77c7e1b by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown

@DigHuang DigHuang merged commit 347f2dd into feat/skill-edit May 19, 2026
1 of 2 checks passed
@DigHuang DigHuang deleted the codex/skill-create-detail-loading branch May 19, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant