Merge bitcoin#25963: CBlockLocator: performance-move-const-arg Clang tidy fixup

6b24dfe CBlockLocator: performance-move-const-arg Clang tidy fixups (Jon Atack)

Pull request description:

  Fix Clang-tidy CI errors on master.  See https://cirrus-ci.com/task/4806752200818688?logs=ci#L4696 for an example.

ACKs for top commit:
  MarcoFalke:
    review ACK 6b24dfe
  vasild:
    ACK 6b24dfe

Tree-SHA512: 7a67acf7b42da07b63fbb392236e9a7be8cf35c36e37ca980c4467fe8295c2eda8aef10f41a1e3036cd9ebece47fa957fc3256033f853bd6a97ce2ca42799a0a

Author: claude

src/chain.cpp

@@ -54,7 +54,7 @@ CBlockLocator CChain::GetLocator(const CBlockIndex *pindex) const {
             nStep *= 2;
     }
 
-    return CBlockLocator(vHave);
+    return CBlockLocator(std::move(vHave));
 }
 
 const CBlockIndex *CChain::FindFork(const CBlockIndex *pindex) const {

src/primitives/block.h

@@ -242,7 +242,7 @@ struct CBlockLocator
 
     CBlockLocator() {}
 
-    explicit CBlockLocator(const std::vector<uint256>& vHaveIn) : vHave(vHaveIn) {}
+    explicit CBlockLocator(std::vector<uint256>&& have) : vHave(std::move(have)) {}
 
     SERIALIZE_METHODS(CBlockLocator, obj)
     {