Repository navigation
Commit d153488
committed
fix(e2e): harden assertions, fix Mac2 navigation, update Skills page selectors
E2E spec fixes across all flow specs:
- Replace tautological `res.ok || Boolean(res.error)` assertions with
explicit success/failure checks and diagnostic logging in discord-flow,
gmail-flow, notion-flow, macos-distribution, automation-scheduling,
chat-interface-flow, system-resource-access, and login-flow specs
- Fix channel_web_chat payload shape: use {client_id, thread_id, message}
instead of wrong {input, channel, target} keys
- Update Skills page selectors for new filter tab UI: use "Channels" tab
for Telegram/Discord, "Other" tab for Gmail/Notion (replaces old
"Channel Integrations" / "3rd Party Skills" section headings)
- Fix CTA button text: "Setup"/"Enable"/"Manage" instead of "Configure"
- Fix Notion Enable click: use last matching XPath button (Notion appears
after Gmail) to avoid clicking Gmail's Enable button
- Fix Mac2 scroll: replace W3C wheel actions (unsupported) with native
macos:scroll CGEvent in scrollDownInPage
- Add TaskRecurrence::try_cron validated constructor; use it in RPC
handler and DB deserialization with Pending fallback for corrupt data
- Poll subconscious_log_list with timeout instead of fixed sleep in both
E2E spec and json_rpc_e2e.rs integration test
- Add missing-param validation test for cron_run (empty job_id)
- Strengthen login-flow macOS fallback: assert isAuthenticated/token
instead of just RPC reachability
- Accept network errors in macos-distribution app_state_snapshot test
(no mock server in that spec)1 parent c233dc4 commit d153488
14 files changed
Lines changed: 478 additions & 227 deletions
File tree
- app/test/e2e
- helpers
- specs
- src/openhuman/subconscious
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
430 | | - | |
| 430 | + | |
431 | 431 | | |
432 | 432 | | |
433 | 433 | | |
| |||
440 | 440 | | |
441 | 441 | | |
442 | 442 | | |
443 | | - | |
| 443 | + | |
444 | 444 | | |
445 | 445 | | |
446 | 446 | | |
| |||
449 | 449 | | |
450 | 450 | | |
451 | 451 | | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | | - | |
456 | | - | |
457 | | - | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
462 | 459 | | |
463 | 460 | | |
464 | 461 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
143 | 146 | | |
144 | 147 | | |
145 | 148 | | |
146 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
147 | 181 | | |
148 | 182 | | |
149 | 183 | | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
150 | 189 | | |
151 | 190 | | |
152 | 191 | | |
| |||
156 | 195 | | |
157 | 196 | | |
158 | 197 | | |
159 | | - | |
160 | | - | |
161 | | - | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
162 | 210 | | |
163 | 211 | | |
164 | 212 | | |
| 213 | + | |
165 | 214 | | |
166 | 215 | | |
167 | 216 | | |
168 | 217 | | |
169 | 218 | | |
170 | | - | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
171 | 243 | | |
172 | 244 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | | - | |
112 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
113 | 113 | | |
114 | | - | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
115 | 134 | | |
116 | 135 | | |
117 | 136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
| |||
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
104 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
105 | 111 | | |
106 | 112 | | |
107 | 113 | | |
| |||
115 | 121 | | |
116 | 122 | | |
117 | 123 | | |
118 | | - | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
119 | 128 | | |
120 | 129 | | |
121 | 130 | | |
| |||
156 | 165 | | |
157 | 166 | | |
158 | 167 | | |
159 | | - | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
160 | 172 | | |
161 | 173 | | |
162 | 174 | | |
| |||
173 | 185 | | |
174 | 186 | | |
175 | 187 | | |
176 | | - | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
177 | 192 | | |
178 | 193 | | |
179 | 194 | | |
180 | 195 | | |
181 | | - | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
182 | 200 | | |
183 | 201 | | |
184 | 202 | | |
| |||
231 | 249 | | |
232 | 250 | | |
233 | 251 | | |
234 | | - | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
235 | 266 | | |
236 | 267 | | |
237 | 268 | | |
| |||
241 | 272 | | |
242 | 273 | | |
243 | 274 | | |
244 | | - | |
245 | | - | |
| 275 | + | |
246 | 276 | | |
247 | 277 | | |
248 | 278 | | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
262 | 285 | | |
263 | 286 | | |
264 | | - | |
265 | | - | |
266 | | - | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
267 | 290 | | |
268 | | - | |
269 | | - | |
| 291 | + | |
270 | 292 | | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
275 | 298 | | |
276 | 299 | | |
277 | 300 | | |
| |||
0 commit comments