fix(Euler): upstream dev/harry changes and sync Codex skills - #23
Merged
harryzhou2000 merged 5 commits intoAug 25, 2026
Merged
Conversation
Add a parameterized CGNS generator for periodic wave meshes used by the scalar/vector Fourier analysis. The script supports configurable cell count, domain length, and origin so h/2h/4h meshes can share an aligned physical core while retaining periodic boundary face records. Verification: py_compile scripts/generate_8x8_wave_cgns.py; generated and read-validated the 8x8, 6x6 h2, and 5x5 h4 meshes during Fourier analysis work; regenerated MGTestFourier integrated plots. committed by opencode with model internal_openai/openai/openai/gpt-5.5
Move model-specific RANS configuration types next to the inline RANS kernels and thread concrete config objects through all RANS primitive call paths. Raise the default SA production cap from 100 to 1e5 to recover ordinary-SA convergence while preserving Orion behavior with an explicit limit of 100. Expose existing k-omega, SST, and realizable-k-epsilon hard limits without changing their historical defaults, regenerate Euler schemas, and add focused config and SA source-limit tests. Document that formatting is owned by the pre-commit hook and the repository formatting script. Verification: built all eight non-EulerP Euler executables with -j8; euler_test_rans passed 29 cases and 66 assertions. committed by codex with model gpt-5.6-sol
harryzhou2000
marked this pull request as ready for review
August 25, 2026 14:35
Collaborator
Author
|
/ci run |
Collaborator
Author
|
/ci-run |
Repair reactive cell-mean species after initialization and restart loading, while validating that density and temperature remain physical. Share the species repair logic with fixed-increment updates so initialization follows the same conservative correction policy. Use a temporary simplex-repaired composition for chemical source evaluation at reconstructed quadrature points. Keep convective and diffusive transported species values unprojected, and document that only thermodynamic and transport properties use repaired mass fractions. Add MPI evaluator coverage for repaired reactive cell means. Verified the focused test at 1, 2, 4, and 8 ranks and ran the large 16-rank non-Strang detonation case through two coupled RHS iterations past the former strict mass-fraction failure. committed by codex with model gpt-5
Expose the existing OpenCode skill tree through a relative .codex/skills symlink so both agent environments share one maintained source. Normalize the skill frontmatter for Codex validation and link the PyVista helper to the canonical detonation2d renderer instead of retaining a stale duplicate. Clean the pre-existing trailing whitespace in the CRM run config included by the branch. Validation performed before the final no-check directive: all three skills passed Codex quick_validate; bundled Python helpers compiled and their help entry points loaded. No C++ build or unit tests were run to completion, per request. committed by codex with model deepseek-v4-flash
harryzhou2000
force-pushed
the
harry/fix/dev-harry-main-20260825
branch
from
August 25, 2026 15:30
a55a0e5 to
34a57be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation