Merge pull request keepkey#221 from keepkey/fix/7142-makerdao-advanced-mode-tests

test(ethereum): require advanced mode for MakerDAO calldata

Author: pastaghost

tests/test_msg_ethereum_makerdao.py

@@ -30,6 +30,8 @@ class TestMsgEthereumtxMakerDAO(common.KeepKeyTest):
     def test_generate(self):
         self.requires_fullFeature()
         self.setup_mnemonic_nopin_nopassphrase()
+        # MakerDAO calldata now follows the generic blind-signing path.
+        self.client.apply_policy("AdvancedMode", 1)
 
         sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
             n=[2147483692,2147483708,2147483648,0,0],
@@ -50,6 +52,8 @@ def test_generate(self):
     def test_deposit(self):
         self.requires_fullFeature()
         self.setup_mnemonic_nopin_nopassphrase()
+        # MakerDAO calldata now follows the generic blind-signing path.
+        self.client.apply_policy("AdvancedMode", 1)
 
         sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
             n=[2147483692,2147483708,2147483648,0,0],
@@ -71,6 +75,8 @@ def test_deposit(self):
     def test_close(self):
         self.requires_fullFeature()
         self.setup_mnemonic_nopin_nopassphrase()
+        # MakerDAO calldata now follows the generic blind-signing path.
+        self.client.apply_policy("AdvancedMode", 1)
 
         sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
             n=[2147483692,2147483708,2147483648,0,0],
@@ -92,6 +98,8 @@ def test_close(self):
     def test_free(self):
         self.requires_fullFeature()
         self.setup_mnemonic_nopin_nopassphrase()
+        # MakerDAO calldata now follows the generic blind-signing path.
+        self.client.apply_policy("AdvancedMode", 1)
 
         sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
             n=[2147483692,2147483708,2147483648,0,0],
@@ -111,4 +119,3 @@ def test_free(self):
 
 if __name__ == '__main__':
     unittest.main()
-

tests/test_msg_solana_signtx.py

@@ -277,7 +277,7 @@ def test_solana_sign_token_transfer(self):
         with pytest.raises(CallException) as exc:
             self.client.call(messages.SolanaSignTx(
                 address_n=parse_path("m/44'/501'/0'/0'"), raw_tx=raw_tx))
-        self.assertIn("policy", str(exc.value))
+        self.assertIn("AdvancedMode", str(exc.value))
 
     def test_solana_sign_token_approve(self):
         """Unchecked SPL Approve is opaque because no mint is signed."""