Commit b99e287
committed
report: capture the shielded confirm screens, which nothing has ever shown
The RC run produced 1037 OLED frames. Not one matches pczt, orchard,
shielded or ironwood. Every catalogued Zcash PCZT test carries an empty
screenshot list, so the screenshot filter never selected any of them and no
shielded confirm screen has ever been rendered into the evidence.
That blind spot hid a real defect. The per-output shielded confirm builds
"Send shielded ZEC?\n<unified address>\nAmount: %s" for a three-row body,
and a real Orchard unified address is 106 characters -- three full rows on
its own, as the captured display-address frame shows. So the address tail
and the entire Amount line are never drawn. It is not a cosmetic screen
either: fsm_msg_zcash.h says total_amount is "a summary prompt" and that
Orchard output values "have their own verification gates", and this is that
gate. total_amount itself is taken straight from the host message.
Nothing looked wrong from outside, because the two Zcash flows that do get
captured both render correctly: the transparent output screen has a ~35
character t-address that fits, and display-address uses the paged
confirm_zcash_address path that handles all 106 characters.
Request frames on the one catalogued test that exercises a real shielded
output. This does not fix the rendering -- it makes the screen visible to
review, so the fix can be checked against a captured frame instead of an
assertion.
Verified: --screenshot-filter now selects the test, and the report still
renders 325 tests and passes --validate-junit against the RC artifacts.1 parent 74768b0 commit b99e287
1 file changed
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2038 | 2038 | | |
2039 | 2039 | | |
2040 | 2040 | | |
2041 | | - | |
2042 | | - | |
| 2041 | + | |
| 2042 | + | |
| 2043 | + | |
| 2044 | + | |
| 2045 | + | |
| 2046 | + | |
| 2047 | + | |
| 2048 | + | |
2043 | 2049 | | |
2044 | 2050 | | |
2045 | 2051 | | |
| |||
0 commit comments