Implement UI audit improvements and harden dev asset checks#397
Merged
Conversation
- Replace repository-wide generated-artifact cleanliness check with generation + explicit output/track validation script - Add new artifact verification and tests to ensure required generated files exist and remain untracked - Update vendor and build/test coverage for new dependency entrypoints (notably isows/viem) and related UI import-map/runtime resolution - Apply accessibility/UX updates across header, controls, simulation banner, and copyable elements with new tests
# Conflicts: # scripts/check-generated-artifacts.mts
KillariDev
changed the title
- Switch create form fields to user-facing decimal input modes and guidance text - Add decimal parsing/formatting helpers for fee percentages and token/ERC-ETH amounts - Parse form submission through token-decimal-aware conversion path using token1 decimals from-chain - Update open-oracle tests and integration route assertions for new input semantics
- In `solidity/ts/tests/peripherals/receiveGuards.test.ts`, wrap unauthorized send tx in `writeContractAndWait` to ensure transaction lifecycle is awaited - Keeps the receive-guards assertion behavior unchanged while using the shared simulator helper for consistency
Collaborator
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isowsvendor mapping used by viem, and restoring generated-artifact policy checks as a testable script.Testing
bun test ui/ts/tests/errorNotice.test.tsx ui/ts/tests/securityPoolsOverviewSection.test.tsx ui/ts/tests/liquidationModal.test.tsx ui/ts/tests/simulationBanner.test.tsx ui/ts/tests/errors.test.ts ui/ts/tests/openOracleSection.integration.test.tsxbun test ui/build/sharedAssets.test.tsui/jsandui/vendortemporarily moved asidebun test scripts/check-generated-artifacts.test.tsbun run tscbun run test(1433 pass,11 skip,0 failafter mergingorigin/main)bun run formatbun run checkbun run knipbun run check:generated-cleangit diff --checkReview notes
origin/mainand resolved the only conflict inscripts/check-generated-artifacts.mtsby keeping the exported/testable checker while preserving CLI behavior.96.