Lock Origin Pool Retention to Protocol Baseline and Update Mainnet Addresses#379
Merged
Conversation
- Update mainnet deployment addresses for deployment status oracle and security pool factory - Ignore caller-supplied retention input on origin pool creation and enforce security multiplier > 1 in UI and factory - Show fixed initial open-interest fee in pool creation UI and compute it from on-chain protocol value - Add tests confirming retention derives from protocol math and input validation changes
# Conflicts: # docs/mainnet-deployment-addresses.json # docs/mainnet-deployment-addresses.md
- Drop the retained `currentRetentionRate` argument from `deployOriginSecurityPool` in Solidity interface and implementation - Update all contract callers/helpers/tests across solidity and UI to use three-argument deployment - Remove retention-rate fields from market creation form/types and related UI/simulation code paths - Refresh mainnet deployment-address docs to match newly deployed peripheral contracts
Collaborator
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploymentStatusOracleto0x76ca5D8c891b8c285831Bb62DdC3141569E43e14andsecurityPoolFactoryto0x1B2973a1bD9A4459e8Cd517B92ea1433cB0eAccA.SecurityPoolFactoryorigin deployment flow to ignore caller-supplied retention and initialize origin pools with protocol baseline retention viaSecurityPoolUtils.calculateRetentionRate(0, 0).securityMultiplier > 1enforcement for origin pool deployment to prevent locked unsafe parameters by first deployers.createSecurityPoolParameters.0,1) are rejected,Testing
solidity/ts/tests/peripherals/deploymentAndOwnForkEscalation.test.ts(new origin retention derivation test)ui/ts/tests/marketCreation.test.tsui/ts/tests/securityPoolSection.test.tsxbun run tsc,bun run check,bun run test, targeted Solidity/UI test command(s).