Skip to content

Commit 28fae9d

Browse files
committed
ci(windows): run the docs step under bash
The Windows job's default shell is pwsh, where a trailing backslash is not a line continuation. It parsed --exclude as a unary operator and the step failed before cargo ran, which is how the job this PR adds the step to went red. bash rather than folding the command onto one line, so it stays byte-identical to the Linux rustdoc job it exists to mirror.
1 parent 8c46115 commit 28fae9d

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,10 @@ jobs:
313313
- name: cargo doc
314314
env:
315315
RUSTDOCFLAGS: "-D warnings"
316+
# This job's default shell is pwsh, where a trailing backslash is not a
317+
# line continuation and `--exclude` parses as a unary operator. bash keeps
318+
# this command byte-identical to the Linux rustdoc job it mirrors.
319+
shell: bash
316320
run: |
317321
cargo doc --workspace --no-deps --document-private-items \
318322
--exclude openlogi-ui \

0 commit comments

Comments
 (0)