fix(workspace): a missing workspace also clears a cached "memory off", and warns once (review)

- `memoryStatus` clears `memoryDisabledMemo` as well when the workspace is missing from the list, so cache-only readers (`workspace status` without a poll, the identity section) say unknown instead of a stale "disabled"
- The "missing from the workspace list" warning is logged once per workspace while it stays missing

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fJ3X7pcGT4R9yzjsJnqsV

Author: sahrizvi

packages/opencode/src/altimate/workspace/memory-sync.ts

@@ -213,6 +213,8 @@ export function resetEnablementMemoForTests(): void {
 
 /** Warn once per workspace, not once per write. */
 const missingFieldWarned = new Set<number>()
+/** Workspaces already reported missing from the list, so a lag of a few minutes warns once, not on every call. */
+const missingFromListWarned = new Set<number>()
 
 /** Whether the bound workspace has memory switched on.
  *
@@ -246,12 +248,17 @@ async function memoryStatus(
     const match = workspaces.find((w) => w.id === binding.datamateId)
     if (!match) {
       // Missing from the list is not a confirmed toggle. The list lags a workspace created moments ago (one
-      // service replica serves it stale for a few minutes), so this is unknown, like a failed request: not
-      // cached either way, and the write path still fails closed on it.
+      // service replica serves it stale for a few minutes), so this is unknown, like a failed request: neither
+      // verdict is kept, so cache-only readers say unknown too, and the write path still fails closed on it.
       memoryEnabledCache.delete(binding.datamateId)
-      log.warn("workspace missing from the workspace list; memory setting unknown", { workspace: binding.datamateId })
+      memoryDisabledMemo.delete(binding.datamateId)
+      if (!missingFromListWarned.has(binding.datamateId)) {
+        missingFromListWarned.add(binding.datamateId)
+        log.warn("workspace missing from the workspace list; memory setting unknown", { workspace: binding.datamateId })
+      }
       return "error"
     }
+    missingFromListWarned.delete(binding.datamateId)
     if (match.memoryEnabled === undefined && !missingFieldWarned.has(binding.datamateId)) {
       // Fail-closed is right, but a backend that has not shipped the field
       // turns the whole feature into a silent no-op. Say so once.

packages/opencode/test/altimate/workspace/memory-sync.test.ts

@@ -898,6 +898,17 @@ describe("memory_enabled", () => {
     expect(memoryEnabledCached(BINDING as any)).toBe("unknown")
     expect(callsTo("/datamates/memory/", "POST").length).toBe(0)
   })
+
+  test("a workspace last seen with memory off that drops out of the list reads as unknown, not off", async () => {
+    // The cache-only readers (`workspace status` without a poll, the identity section) must not keep serving the
+    // earlier "disabled" while the list cannot say anything about the workspace.
+    workspaces = [{ id: 42, name: "acme", memory_enabled: false }]
+    await backfill([block({ id: "was-off" })], BINDING as any)
+    expect(memoryEnabledCached(BINDING as any)).toBe("disabled")
+    workspaces = []
+    await backfill([block({ id: "now-missing" })], BINDING as any)
+    expect(memoryEnabledCached(BINDING as any)).toBe("unknown")
+  })
 })
 
 // ── read path ───────────────────────────────────────────────────────────────