test(workspace): fail any test that leaves a skill sync running

Tests that recorded a link without `awaitBackfill`, or used the TUI create
path, left syncs running into later files; some never settled and stalled
every later `flushPendingSyncs()`. Await them, fix the one test that relied on
the leak, and check for leaks in the test preload.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0174HUYiaceApqHP7EKMNgnb

Author: ralphstodomingo

packages/opencode/test/altimate/plugin/workspace.test.ts

@@ -156,7 +156,7 @@ describe("workspace binding cache", () => {
       repoRemote: "git@github.com:acme/proj-a.git",
       projectPath: "/work/proj-a",
       linkedAt: 1_700_000_000_000,
-    })
+    }, { awaitBackfill: true })
 
     const read = await readLocalBinding("/work/proj-a")
     expect(read).not.toBeNull()
@@ -470,7 +470,7 @@ describe("workspace binding cache", () => {
       repoRemote: "git@github.com:acme/x.git",
       projectPath: "/work/proj-a",
       linkedAt: 1,
-    })
+    }, { awaitBackfill: true })
     expect(existsSync(cachePath())).toBe(true)
     const mode = statSync(cachePath()).mode & 0o777
     expect(mode).toBe(0o600)
@@ -483,7 +483,7 @@ describe("workspace binding cache", () => {
       repoRemote: "git@github.com:acme/proj-a.git",
       projectPath: "/work/proj-a",
       linkedAt: 1,
-    })
+    }, { awaitBackfill: true })
 
     // Switch account → the cached binding must not be surfaced.
     unstubCreds()
@@ -500,7 +500,7 @@ describe("workspace binding cache", () => {
       repoRemote: "git@github.com:acme/proj-a.git",
       projectPath: "/work/proj-a",
       linkedAt: 1,
-    })
+    }, { awaitBackfill: true })
 
     unstubCreds()
     stubCreds("acme", "https://different-host.example.com")
@@ -516,7 +516,7 @@ describe("workspace binding cache", () => {
       repoRemote: "git@github.com:acme/proj-a.git",
       projectPath: "/work/proj-a",
       linkedAt: 1,
-    })
+    }, { awaitBackfill: true })
     const read = await readLocalBinding("/work/proj-b")
     expect(read).toBeNull()
   })

packages/opencode/test/altimate/workspace/create-then-rebind.test.ts

@@ -48,6 +48,7 @@ const { createAndBindInline, bindOrRebindInline, runWorkspaceManage } = await im
   "@/plugin/tui/altimate/workspace"
 )
 const { recordApprovedBinding } = await import("@/altimate/workspace/state")
+const { flushPendingSyncs } = await import("@/altimate/workspace/skill-sync")
 const { HIDDEN_BINDING_MESSAGE, QUICK_WORKSPACE_PRIVATE_NOTE } = await import(
   "@/altimate/workspace/api-client"
 )
@@ -116,7 +117,10 @@ beforeEach(() => {
   opened.length = 0
   stubFetch()
 })
-afterEach(() => {
+afterEach(async () => {
+  // The TUI create leaves its skill sync detached so the dialog can close at once. Settled here,
+  // against this file's stub, so it cannot run on into the next test.
+  await flushPendingSyncs()
   globalThis.fetch = ORIGINAL_FETCH
   process.exitCode = 0 // Bun ignores `= undefined`; a leaked 1 fails later files
 })
@@ -420,7 +424,7 @@ describe("TUI: /workspace menu options", () => {
       repoRemote: BINDING.repo_remote,
       projectPath: null,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     const m = menuApi()
     await runWorkspaceManage(m.api, "/tmp/proj")
     const values = m.cap.options.map((o) => o.value)

packages/opencode/test/altimate/workspace/identity-section.test.ts

@@ -123,7 +123,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     resetEnablementMemoForTests()
     memoryEnabledCache.set(77, { checkedAt: Date.now() })
     try {
@@ -244,7 +244,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     expect(await inProject(systemSection)).toContain('is "analytics"')
     await clearLocalBinding(projectDir, { scope: ACME_SCOPE })
     globalThis.fetch = (async () =>
@@ -283,7 +283,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now() - 10 * 60 * 1000,
-    })
+    }, { awaitBackfill: true })
     const { expireValidationForTests } = await import("../../../src/altimate/workspace/state")
     expireValidationForTests?.(projectDir)
     let unlinkedMidFlight = false
@@ -329,7 +329,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now() - 10 * 60 * 1000,
-    })
+    }, { awaitBackfill: true })
     const { expireValidationForTests } = await import("../../../src/altimate/workspace/state")
     expireValidationForTests(projectDir)
     globalThis.fetch = (async () => {
@@ -399,7 +399,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now() - 10 * 60 * 1000,
-    })
+    }, { awaitBackfill: true })
     const { expireValidationForTests } = await import("../../../src/altimate/workspace/state")
     expireValidationForTests(projectDir)
     // First step: bound (served from cache while the server is asked).
@@ -427,7 +427,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: other,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     globalThis.fetch = (async () =>
       new Response(JSON.stringify({ detail: "not found" }), {
         status: 404,
@@ -469,7 +469,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     expect(await inProject(systemSection)).toContain('is "Linked"')
   })
 
@@ -484,15 +484,13 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now() - 10 * 60 * 1000,
-    })
+    }, { awaitBackfill: true })
     const { expireValidationForTests } = await import("../../../src/altimate/workspace/state")
     expireValidationForTests(projectDir)
     let release!: () => void
     const gate = new Promise<void>((r) => (release = r))
     let firstStarted!: () => void
     const firstOnWire = new Promise<void>((r) => (firstStarted = r))
-    let secondStarted!: () => void
-    const secondOnWire = new Promise<void>((r) => (secondStarted = r))
     let calls = 0
     globalThis.fetch = (async () => {
       calls++
@@ -507,7 +505,6 @@ describe("systemSection", () => {
           { status: 200, headers: { "content-type": "application/json" } },
         )
       }
-      secondStarted()
       return new Response(JSON.stringify({ detail: "not found" }), {
         status: 404,
         headers: { "content-type": "application/json" },
@@ -516,11 +513,12 @@ describe("systemSection", () => {
     const first = inProject(systemSection)
     await firstOnWire // step 1's request is out and parked on the gate
     await clearLocalBinding(projectDir, { scope: ACME_SCOPE })
-    const second = inProject(systemSection)
-    await secondOnWire // step 2 made its OWN request while step 1 was still pending
+    // Step 2 answers while step 1 is still parked. The unlink records this project as unbound, so
+    // step 2 needs no request of its own; joined to step 1's resolve, it could only render what
+    // step 1 knew.
+    const next = await inProject(systemSection)
     release()
-    const [, next] = await Promise.all([first, second])
-    expect(calls).toBe(2)
+    await first
     expect(next).not.toContain('is "old"')
     expect(next).toContain("No Altimate Workspace")
   })
@@ -599,7 +597,7 @@ describe("systemSection", () => {
         repoRemote: null,
         projectPath: projectDir,
         linkedAt: Date.now(),
-      })
+      }, { awaitBackfill: true })
       setCreds("acme")
       let switched = false
       globalThis.fetch = (() =>
@@ -634,7 +632,7 @@ describe("systemSection", () => {
         repoRemote: null,
         projectPath: projectDir,
         linkedAt: Date.now(),
-      })
+      }, { awaitBackfill: true })
       let t = 5_000_000
       setClockForTests(() => t)
       expect(await inProject(systemSection)).toContain('is "mine"') // memo filled for A
@@ -746,7 +744,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     const saved: Record<string, string | undefined> = {}
     const pinEnv: Record<string, string> = {
       ALTIMATE_CODE_SERVE: "1",
@@ -787,7 +785,7 @@ describe("systemSection", () => {
       repoRemote: null,
       projectPath: projectDir,
       linkedAt: Date.now(),
-    })
+    }, { awaitBackfill: true })
     const saved: Record<string, string | undefined> = {}
     const pinEnv: Record<string, string> = {
       ALTIMATE_CODE_SERVE: "1",

packages/opencode/test/altimate/workspace/launch-resolve.test.ts

@@ -120,7 +120,7 @@ describe("resolveWorkspaceForLaunch", () => {
       repoRemote: null,
       projectPath: DIRECTORY,
       linkedAt: 0,
-    })
+    }, { awaitBackfill: true })
   })
 
   test("no --workspace arg → no env var set, no-op", async () => {

packages/opencode/test/altimate/workspace/manage.test.ts

@@ -371,7 +371,7 @@ describe("renames", () => {
         repoRemote: "git@github.com:acme/app.git",
         projectPath: projectDir,
         linkedAt: Date.now(),
-      } as any)
+      } as any, { awaitBackfill: true })
       expect(fired).toBeGreaterThan(0)
     } finally {
       stop()

packages/opencode/test/altimate/workspace/memory-sync.test.ts

@@ -1199,7 +1199,7 @@ describe("reaping blocks archived elsewhere", () => {
         await recordApprovedBinding(
           here,
           { datamateId: 99, datamateName: "other", repoRemote: null, projectPath: here, linkedAt: Date.now() },
-          { seed: false },
+          { awaitBackfill: true, seed: false },
         )
       }
       return inner(scope, id, directory)
@@ -1705,7 +1705,7 @@ describe("binding changes", () => {
     const b = { ...BINDING, datamateId: 43, datamateName: "beta", projectPath: dir, linkedAt: 2 }
     workspaces = [...workspaces, { id: 43, name: "beta", memory_enabled: true }]
     syncInternals.resolveBinding = async () => b as any
-    await recordApprovedBinding(dir, b)
+    await recordApprovedBinding(dir, b, { awaitBackfill: true })
     await hydrate(SES)
     expect(overlayBlocks(SES).map((x) => x.id)).toEqual(["from-b"])
   })
@@ -1721,7 +1721,7 @@ describe("binding changes", () => {
       // The first lookup adopts (and notifies); later ones read the cache, as in production.
       if (!adopted) {
         adopted = true
-        await recordApprovedBinding(dir, { ...BINDING, projectPath: dir, linkedAt: 3 }, { seed: false })
+        await recordApprovedBinding(dir, { ...BINDING, projectPath: dir, linkedAt: 3 }, { awaitBackfill: true, seed: false })
       }
       return BINDING as any
     }
@@ -1752,7 +1752,7 @@ describe("refresh racing a relink", () => {
     await reachedList
     const { recordApprovedBinding } = await import("../../../src/altimate/workspace/state")
     const dir = mkdtempSync(path.join(SANDBOX, "race-"))
-    await recordApprovedBinding(dir, { ...BINDING, datamateId: 44, projectPath: dir, linkedAt: 4 }, { seed: false })
+    await recordApprovedBinding(dir, { ...BINDING, datamateId: 44, projectPath: dir, linkedAt: 4 }, { awaitBackfill: true, seed: false })
     release?.()
     const result = await pending
     // Superseded: neither its read nor the prior overlay belongs to the new binding.
@@ -1776,7 +1776,7 @@ describe("overlay invalidation", () => {
     await hydrate(SES)
     expect(overlayBlocks(SES).length).toBe(1)
     const dir = mkdtempSync(path.join(SANDBOX, "hide-"))
-    await recordApprovedBinding(dir, { ...BINDING, datamateId: 45, projectPath: dir, linkedAt: 5 }, { seed: false })
+    await recordApprovedBinding(dir, { ...BINDING, datamateId: 45, projectPath: dir, linkedAt: 5 }, { awaitBackfill: true, seed: false })
     expect(overlayBlocks(SES)).toEqual([])
   })
 
@@ -1819,7 +1819,7 @@ describe("epoch bracketing and scope", () => {
       calls++
       // First lookup returns A, but the relink to B lands before it returns.
       if (calls === 1) {
-        await recordApprovedBinding(dir, { ...BINDING, datamateId: 46, projectPath: dir, linkedAt: 6 }, { seed: false })
+        await recordApprovedBinding(dir, { ...BINDING, datamateId: 46, projectPath: dir, linkedAt: 6 }, { awaitBackfill: true, seed: false })
         return BINDING as any
       }
       return { ...BINDING, datamateId: 46 } as any
@@ -1841,10 +1841,10 @@ describe("epoch bracketing and scope", () => {
     const other = mkdtempSync(path.join(SANDBOX, "other-"))
     await refresh(SES, mine)
     expect(overlayBlocks(SES).map((x) => x.id)).toEqual(["mine"])
-    await recordApprovedBinding(other, { ...BINDING, datamateId: 47, projectPath: other, linkedAt: 7 }, { seed: false })
+    await recordApprovedBinding(other, { ...BINDING, datamateId: 47, projectPath: other, linkedAt: 7 }, { awaitBackfill: true, seed: false })
     expect(overlayBlocks(SES).map((x) => x.id)).toEqual(["mine"])
     // A change to this project's own binding still hides it.
-    await recordApprovedBinding(mine, { ...BINDING, datamateId: 48, projectPath: mine, linkedAt: 8 }, { seed: false })
+    await recordApprovedBinding(mine, { ...BINDING, datamateId: 48, projectPath: mine, linkedAt: 8 }, { awaitBackfill: true, seed: false })
     expect(overlayBlocks(SES)).toEqual([])
   })
 })
@@ -1887,7 +1887,7 @@ describe("superseded failures", () => {
     await reachedList
     const dir = mkdtempSync(path.join(SANDBOX, "supersede-"))
     syncInternals.resolveBinding = async () => b as any
-    await recordApprovedBinding(dir, { ...b, projectPath: dir, linkedAt: 9 }, { seed: false })
+    await recordApprovedBinding(dir, { ...b, projectPath: dir, linkedAt: 9 }, { awaitBackfill: true, seed: false })
     release?.()
     await first
     failList = false

packages/opencode/test/altimate/workspace/routing-pin.test.ts

@@ -39,6 +39,27 @@ function stubCreds() {
     ({ altimateInstanceName: "acme", altimateUrl: "https://api.test", altimateApiKey: "k" }) as Creds
 }
 
+const originalFetch = globalThis.fetch
+
+/** Seeding a link runs a skill sync (awaited, see `seedLocalLink`) that lists the workspace's
+ * skills from `api.test`. Answered here with an empty page, so that sync finishes offline instead
+ * of waiting on however long a resolver takes to fail a name that cannot exist. */
+function stubFetch() {
+  globalThis.fetch = (async (input: string | URL, init?: RequestInit) => {
+    const url = new URL(String(input))
+    if (url.host !== "api.test") return originalFetch(input, init)
+    const skills = url.pathname.endsWith("/skills")
+    // The page is echoed back: the skill-list parser rejects a page that does not match its request.
+    const body = skills
+      ? { items: [], page: Number(url.searchParams.get("page") ?? "1"), pages: 1, total: 0 }
+      : { detail: "not found" }
+    return new Response(JSON.stringify(body), {
+      status: skills ? 200 : 404,
+      headers: { "content-type": "application/json" },
+    })
+  }) as typeof fetch
+}
+
 let listCalls = 0
 
 function stubList(rows: { id: number; name: string }[]) {
@@ -105,6 +126,7 @@ beforeEach(() => {
   listCalls = 0
   __resetPinValidation()
   stubCreds()
+  stubFetch()
   stubList([
     { id: 42, name: "pinned-workspace" },
     { id: 7, name: "project-link" },
@@ -133,6 +155,7 @@ afterAll(() => {
   ;(AltimateApi as unknown as { isConfigured: unknown }).isConfigured = originalIsConfigured
   ;(AltimateApi as unknown as { getCredentials: unknown }).getCredentials = originalGetCreds
   ;(WorkspaceApi as unknown as { listDatamates: unknown }).listDatamates = originalList
+  globalThis.fetch = originalFetch
   if (ORIGINAL_XDG_STATE_HOME === undefined) delete process.env.XDG_STATE_HOME
   else process.env.XDG_STATE_HOME = ORIGINAL_XDG_STATE_HOME
   rmSync(SANDBOX, { recursive: true, force: true })

packages/opencode/test/altimate/workspace/state-account-scope.test.ts

@@ -80,7 +80,7 @@ describe("binding cache is scoped to the account, not the tenant", () => {
     // A's cached binding — and loaded A's private workspace's skills — without
     // any visibility check of its own.
     asAccount("key-A")
-    await recordApprovedBinding(ROOT, binding(7, "A's private workspace"), { seed: false })
+    await recordApprovedBinding(ROOT, binding(7, "A's private workspace"), { awaitBackfill: true, seed: false })
     expect((await readLocalBinding(ROOT))?.datamateId).toBe(7)
 
     asAccount("key-B")
@@ -92,7 +92,7 @@ describe("binding cache is scoped to the account, not the tenant", () => {
     // Guards the one above: rejecting every read would satisfy it while making
     // the cache useless.
     asAccount("key-A")
-    await recordApprovedBinding(ROOT, binding(7, "A's private workspace"), { seed: false })
+    await recordApprovedBinding(ROOT, binding(7, "A's private workspace"), { awaitBackfill: true, seed: false })
     asAccount("key-B")
     expect(await readLocalBinding(ROOT)).toBeNull()
 
@@ -102,9 +102,9 @@ describe("binding cache is scoped to the account, not the tenant", () => {
 
   test("a write by the other account evicts this one's rows entirely", async () => {
     asAccount("key-A")
-    await recordApprovedBinding(ROOT, binding(7, "A's workspace"), { seed: false })
+    await recordApprovedBinding(ROOT, binding(7, "A's workspace"), { awaitBackfill: true, seed: false })
     asAccount("key-B")
-    await recordApprovedBinding(ROOT, binding(9, "B's workspace"), { seed: false })
+    await recordApprovedBinding(ROOT, binding(9, "B's workspace"), { awaitBackfill: true, seed: false })
 
     expect((await readLocalBinding(ROOT))?.datamateId).toBe(9)
     asAccount("key-A")
@@ -140,7 +140,7 @@ describe("binding cache is scoped to the account, not the tenant", () => {
     // their row — the cache is per credential now, so it is not theirs to
     // touch.
     asAccount("key-B")
-    await recordApprovedBinding(ROOT, binding(9, "B's workspace"), { seed: false })
+    await recordApprovedBinding(ROOT, binding(9, "B's workspace"), { awaitBackfill: true, seed: false })
     expect((await readLocalBinding(ROOT))?.datamateId).toBe(9)
 
     asAccount("key-A")