Repository navigation
Commit 388f41b
committed
chore(welcome): replace vague "tracked separately" claim with explicit
v0.9.5 review — PM P2. The comment at `welcome.ts:46` referenced a
"pre-existing telemetry-init gap (tracked separately)" — a claim that
implied a tracking issue existed. It didn't (verified by searching open
issues on `AltimateAI/altimate-code`).
Rewritten to:
- Anchor the gap with `FIXME(telemetry-init-config-opt-out)` so it shows
up in code searches.
- Describe the exact failure mode: `doInit()` may run before
`Instance.provide()` has made `Config.get()` resolvable — the catch
branch in `telemetry/index.ts::doInit` proceeds with telemetry enabled,
so a user who opted out via `telemetry.disabled` config (env var not
set) can still have a machine-id minted on cold-start.
- Explicitly note the env-var opt-out
(`ALTIMATE_TELEMETRY_DISABLED` / `OPENCODE_DISABLE_TELEMETRY`) is
unaffected — that check doesn't need Instance context.
- Honestly state no tracking issue currently exists rather than repeat
the earlier false claim.
Pre-existing (not introduced by this release). Filed as part of the
release/v0.9.5 deferred-items tracker.FIXME anchor1 parent 4759a75 commit 388f41b
1 file changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
50 | 56 | | |
51 | 57 | | |
52 | 58 | | |
| |||
0 commit comments