Merge pull request #180 from JasperSurmont/update-cef

Adamcake · web-flow · commit b7565d4478eb · 2025-10-30T11:58:29.000Z
update OnBeforePopup for new CEF versions
diff --git a/src/browser.cxx b/src/browser.cxx
@@ -217,6 +217,7 @@ CefRefPtr<CefLifeSpanHandler> Browser::Window::GetLifeSpanHandler() {
 bool Browser::Window::OnBeforePopup(
 	CefRefPtr<CefBrowser> browser,
 	CefRefPtr<CefFrame> frame,
+	int popup_id,
 	const CefString& target_url,
 	const CefString& target_frame_name,
 	CefLifeSpanHandler::WindowOpenDisposition target_disposition,
diff --git a/src/browser.hxx b/src/browser.hxx
@@ -61,6 +61,7 @@ namespace Browser {
 		bool OnBeforePopup(
 			CefRefPtr<CefBrowser>,
 			CefRefPtr<CefFrame>,
+			int,
 			const CefString&,
 			const CefString&,
 			CefLifeSpanHandler::WindowOpenDisposition,
diff --git a/src/browser/window_osr.cxx b/src/browser/window_osr.cxx
@@ -381,6 +381,7 @@ void Browser::WindowOSR::OnPaint(CefRefPtr<CefBrowser> browser, PaintElementType
 bool Browser::WindowOSR::OnBeforePopup(
 	CefRefPtr<CefBrowser> browser,
 	CefRefPtr<CefFrame> frame,
+	int popup_id,
 	const CefString& target_url,
 	const CefString& target_frame_name,
 	CefLifeSpanHandler::WindowOpenDisposition target_disposition,
diff --git a/src/browser/window_osr.hxx b/src/browser/window_osr.hxx
@@ -57,6 +57,7 @@ namespace Browser {
 		bool OnBeforePopup(
 			CefRefPtr<CefBrowser>,
 			CefRefPtr<CefFrame>,
+			int,
 			const CefString&,
 			const CefString&,
 			CefLifeSpanHandler::WindowOpenDisposition,
diff --git a/src/browser/window_plugin.cxx b/src/browser/window_plugin.cxx
@@ -86,6 +86,7 @@ void Browser::PluginWindow::HandleShowDevtools() {
 bool Browser::PluginWindow::OnBeforePopup(
 	CefRefPtr<CefBrowser> browser,
 	CefRefPtr<CefFrame> frame,
+	int popup_id,
 	const CefString& target_url,
 	const CefString& target_frame_name,
 	CefLifeSpanHandler::WindowOpenDisposition target_disposition,
diff --git a/src/browser/window_plugin.hxx b/src/browser/window_plugin.hxx
@@ -23,6 +23,7 @@ namespace Browser {
 		bool OnBeforePopup(
 			CefRefPtr<CefBrowser>,
 			CefRefPtr<CefFrame>,
+			int,
 			const CefString&,
 			const CefString&,
 			CefLifeSpanHandler::WindowOpenDisposition,
