Propagate request options consistently across service methods

[Lakes41]

Difficulty: Hard

Type: Bug

Summary

Ensure all service methods pass request options such as timeoutMs, retry, and signal through to HttpClient consistently.

Current Behaviour

Some service methods spread or pass request options differently. For example, one access method passes only timeoutMs and retry, while another spreads the options object. This can cause cancellation signals or future request options to work in some methods but not others.

Expected Behaviour

All service methods should accept a common request options type and forward supported options consistently to the HTTP layer.

Suggested Implementation

Create one shared RequestOptions type and use it across access, membership, roles, and guild services. Ensure each method forwards timeoutMs, retry, signal, and any future safe request-level options.

Files or Areas Likely Affected

• src/access/access.service.ts
• src/membership/membership.service.ts
• src/roles/roles.service.ts
• src/guilds/guilds.service.ts
• src/http/http.types.ts
• src/types/common.ts
• tests/

Acceptance Criteria

• All public service methods accept the same request options shape where applicable
• signal is forwarded to HttpClient from every supported service method
• Per-request timeoutMs is forwarded consistently
• Per-request retry overrides are forwarded consistently
• Duplicate or conflicting RequestOptions imports are removed
• Tests cover cancellation and timeout overrides for multiple services

Additional Notes

This should avoid changing the public service method names or response types.

[Neziahtech]

Hello Maintainer, I would love to take this issue

[nelly439]

I’d like to work on this issue.

I have experience maintaining TypeScript SDKs and API client layers, particularly around request handling, cancellation, retries, and type consistency. I can introduce a shared RequestOptions type, standardize option forwarding across all affected services, remove duplicate definitions, and add tests to verify that timeoutMs, retry, and signal are passed through consistently to the HTTP client without changing the existing public API.

[grantfox-oss]

🦊 GrantFox — @nelly439 has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #82)
2. Your PR will be reviewed by the Adamantine-guild maintainers

Good luck! Track your progress on GrantFox.