Refactor data hooks to follow React hook rules

[Lakes41]

Summary

Refactor feature hooks so useQuery is called directly from custom hooks instead of from functions returned by hooks. This reduces the risk of rule-of-hooks violations and makes query behaviour easier to test.

Current Behaviour

Hooks such as useGuilds, useMembership, and useAccessCheck return functions like getGuild, getMembership, and checkAccess. Those functions call useQuery internally when invoked by screen components.

Expected Behaviour

Each query should be exposed as a conventional custom hook such as useGuild, useGuildRoles, useMembership, and useAccessCheckResult, with stable arguments and predictable enabled conditions.

Suggested Implementation

Split the current feature hooks into smaller query hooks. Move query key creation into shared helpers. Update screens to call the new hooks directly at component render time.

Files or Areas Likely Affected

• src/features/guilds/useGuilds.ts
• src/features/membership/useMembership.ts
• src/features/access/useAccessCheck.ts
• app/guilds/[guildId].tsx
• app/access-check.tsx

Acceptance Criteria

• Query hooks are named with the use* convention
• useQuery is not called inside arbitrary callback functions
• Guild detail screen uses direct custom query hooks
• Access check screen uses a direct custom query hook or mutation hook
• Existing loading, error, and empty states continue to work
• Tests cover at least one refactored query hook

Additional Notes

Assumption: current behaviour may work at runtime, but the current pattern makes hook ordering and linting harder to reason about.

[YfengJ]

I would like to apply for this issue if it is still available.

If assigned, I would keep the refactor focused on the hook boundary: split the current returned callback pattern into conventional use* query hooks, centralize query key helpers, update the affected screens to call hooks directly during render, and preserve existing loading/error/empty states. I would also add a focused test around one refactored query hook and run the available lint/typecheck/test commands before opening a PR.

I will wait for assignment or explicit maintainer confirmation before starting implementation or submitting a PR.

[David-patrick-chuks]

Hi, I'd like to work on this issue. I've gone through the description and acceptance criteria and I'm confident I can deliver it. I'll make sure every acceptance criterion is met and submit a clean, tested PR. Please assign it to me.

[MoscowDev]

I'd like to take this issue.

This looks like a structural refactor aimed at aligning the codebase with React Query best practices and eliminating indirect hook execution patterns that can lead to unstable hook behavior and harder-to-test data flows.

My approach would be:

• Audit the current feature hooks (useGuilds, useMembership, useAccessCheck) to map where useQuery is being conditionally or indirectly invoked through returned functions.

• Refactor each feature into explicit query hooks that follow standard React Query patterns:

  • useGuild(guildId)
  • useGuildRoles(guildId)
  • useMembership(userId | guildId)
  • useAccessCheckResult(...)

• Move query key construction into shared, reusable helpers to ensure consistency and avoid cache fragmentation.

• Ensure all hooks call useQuery directly at render time, with properly defined enabled conditions instead of deferred invocation patterns.

• Update dependent screens:

  • app/guilds/[guildId].tsx to consume direct query hooks
  • app/access-check.tsx to use a dedicated access-check query or mutation hook

• Preserve existing loading, error, and empty-state behavior during the refactor.

• Validate that query caching behavior remains consistent after restructuring.

• Add or update tests to cover at least one of the refactored hooks, focusing on:

  • correct query execution
  • enabled/disabled states
  • stable key usage

• Ensure compliance with Rules of Hooks and improve lint safety and predictability of data-fetching behavior.

The goal is to make data fetching more declarative, easier to test, and fully compliant with React Query and hooks rules, removing indirect invocation patterns that can lead to subtle runtime issues.

[grantfox-oss]

🦊 GrantFox — @David-patrick-chuks has been assigned to this issue as part of the Official Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #15)
2. Your PR will be reviewed by the Adamantine-guild maintainers

Good luck! Track your progress on GrantFox.

[YfengJ]

Thanks for the update. I see this has been assigned to @David-patrick-chuks via GrantFox, so I will step back and will not open a competing PR. Good luck with the implementation.